Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(config): correct Zooz ZEN1x timer config params #6648

Merged
merged 2 commits into from
Feb 1, 2024
Merged

fix(config): correct Zooz ZEN1x timer config params #6648

merged 2 commits into from
Feb 1, 2024

Conversation

apella12
Copy link
Contributor

PR description here
Closes #6647

@zwave-js-assistant zwave-js-assistant bot added the config ⚙ Configuration issues or updates label Jan 30, 2024
@AlCalzone
Copy link
Member

AlCalzone commented Feb 1, 2024 •
edited
Loading

Looks like Zooz actually uses the same timer configuration for the Zen1x series as they do for the 0x, 3x and 7x series - except the Zen15 which is different. Such a mess...

@AlCalzone AlCalzone changed the title feat(config): override minValue to Zen14 fix(config): correct Zooz ZEN1x timer config params Feb 1, 2024
@AlCalzone AlCalzone enabled auto-merge (squash) February 1, 2024 09:30
AlCalzone
AlCalzone approved these changes Feb 1, 2024
View reviewed changes
Copy link
Member

@AlCalzone AlCalzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok with my changes

@AlCalzone AlCalzone merged commit 223965f into zwave-js:master Feb 1, 2024
15 checks passed
@TheKorn2
Copy link

TheKorn2 commented Feb 1, 2024

Correct me if I'm wrong, but this doesn't seem to be quite correct for a zen14. The change makes multiple references to config parameter 15, 17, etc. , which don't exist for a zen14. (Example, line 137 of the change.) AFAIK zen14's parameters stop at 8, and the units are not configurable.

https://www.getzooz.com/downloads/zooz-outdoor-double-plug-zen14-manual.pdf

@apella12 apella12 deleted the zen14 branch February 1, 2024 11:57
@apella12
Copy link
Contributor Author

apella12 commented Feb 1, 2024

@TheKorn2
You are fine. Instead of a surgical one-line fix to your device in my PR the template was modified for most all the devices of the 1x series. You have to look carefully to find the changes for your device using the heading. Line 137 was for Zen16. Only params 2-5 were changed for your device to reflect a new imported template that allows for "0".

@AlCalzone
Copy link
Member

AlCalzone commented Feb 1, 2024 •
edited
Loading

Correct. I noticed that the other timer-related parameters for the Zen14 were even wronger and then I noticed that it shared most of the definitions with the other Zen1x series devices, so I cleaned them up too.

This is the relevant part for ZEN14:
https://github.com/zwave-js/node-zwave-js/pull/6648/files#diff-761aff99adad23adfcde190a6015f8454ff440010df1927e1d018d6cfbbfcf83L39-L55

@TheKorn2
Copy link

TheKorn2 commented Feb 1, 2024

Ah! OK Cool.

AlCalzone added a commit that referenced this pull request Feb 10, 2024
@AlCalzone
chore: release v12.4.4
4229045 
### Bugfixes
* NVM backups can now be restored onto 800 series controllers (#6670)

### Config file changes
* Use Color Switch V2 for Inovelli LZW42 (#6654)
* Correct Zooz ZEN1x timer config params (#6648)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlCalzone AlCalzone AlCalzone approved these changes

Assignees
No one assigned
Labels
config ⚙ Configuration issues or updates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot select zero as a configuration value in UI, but can manually type in and send a zero
3 participants
@apella12 @AlCalzone @TheKorn2