Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(config): added 11 Shelly Qubino Wave devices #6633

Merged
merged 17 commits into from
Apr 4, 2024
Merged

feat(config): added 11 Shelly Qubino Wave devices #6633

merged 17 commits into from
Apr 4, 2024

Conversation

QubinoHelp
Copy link
Contributor

added Wave devices i4, i4DC, Plug UK, Plug US, PRO 1, PRO 2, PRO 2, PRO 2PM
added wave_template

fixed errors from previous pull request feat(config): added Wave devices #6610

Shelly Qubino Wave Support and others added 3 commits January 17, 2024 14:14
Plug UK, Plug US, PRO 1, PRO 2, PRO 2, PRO 2PM.
added wave_template
added Wave devices i4, i4DC, Plug UK, Plug US, PRO 1, PRO 2, PRO 2, PRO 2PM
added wave_template
@zwave-js-assistant zwave-js-assistant bot added the config ⚙ Configuration issues or updates label Jan 23, 2024
@apella12
Copy link
Contributor

I'm sure you saw the failed tests. Most are because the "label" is above the "import".
For consistency, config param properties should follow the order "#", "$if", "$import", "label", "description", "valueSize", "unit", "minValue", "maxValue", "defaultValue", "unsigned", "readOnly", "writeOnly", "allowManualEntry", "options" @zwave-js/consistent-device-config-property-order

@QubinoHelp
Copy link
Contributor Author

QubinoHelp commented Jan 23, 2024

@apella12 Yes, I'm fixing that right now.

Is there any way to re-run the tests without doing a new pull? Sorry for the question not so skilled in programming and git
got it :)

Shelly Qubino Wave Support added 3 commits January 23, 2024 14:50
added Wave devices i4, i4DC, Plug UK, Plug US, PRO 1, PRO 2, PRO 2, PRO 2PM
added wave_template

fixed errors from previous pull request feat(config): added Wave devices #6610

Fixes reportd by the lint test
@apella12
Copy link
Contributor

@QubinoHelp Is there any way to re-run the tests without doing a new pull? No that I'm aware of. (I'm assuming you mean after a new commit is added to the PR?) You don't have to delete and start over like you did, just keep adding commits to fix the issues.

I don't know how you are doing this, but you should use VSC, it should show the errors as you go.

@QubinoHelp
Copy link
Contributor Author

I use the VSC I don't have set check all of the code, need more time to set that too :)

@apella12
Copy link
Contributor

Last effort looks close. I think it is just step 2 (zwave lint has passed) at the bottom on this posting to clean up the files.
https://zwave-js.github.io/node-zwave-js/#/config-files/contributing-files

Shelly Qubino Wave Support and others added 5 commits January 24, 2024 11:15
added Wave devices i4, i4DC, Plug UK, Plug US, PRO 1, PRO 2, PRO 2, PRO 2PM, 1 Mini, 1PM Mini, PM Mini
added wave_template
added zwaveAllianceId to Wave 1, Wave 1PM, Wave Plug US, Wave Plug UK, Wave i4, Wave Pro 1, Wave 1PM Mini, Wave 1 Mini

change optimise Wave 1, Wave 1PM, Wave 2PM config using template
change manufacturer name
added Wave devices i4, i4DC, Plug UK, Plug US, PRO 1, PRO 2, PRO 2, PRO 2PM, 1 Mini, 1PM Mini, PM Mini
added wave_template
added zwaveAllianceId to Wave 1, Wave 1PM, Wave Plug US, Wave Plug UK, Wave i4, Wave Pro 1, Wave 1PM Mini, Wave 1 Mini

change optimise Wave 1, Wave 1PM, Wave 2PM config using template
change manufacturer name
@QubinoHelp QubinoHelp changed the title feat(config): added 8 Shelly Qubino Wave devices feat(config): added 11 Shelly Qubino Wave devices Feb 23, 2024
Shelly Qubino Wave Support added 2 commits February 23, 2024 12:11
add Wave 2PM missing parameters
add Wave Plug UK mising parameter
fix Wave Pro 1PM fixed name
@duylong
Copy link

duylong commented Feb 27, 2024

Hi,

I tested the configuration for Wave I4. My device is well recognized, however I cannot make an association with a socket to turn it on/off, "Unable to add Node xx to Group xx of Node xx". Does it work for you?

Tested with an association "On/Off [SW1]" in "Root Endpoint" for "Node Endpoint" and "No Endpoint" for "Target Endpoint".

@QubinoHelp
Copy link
Contributor Author

QubinoHelp commented Feb 27, 2024

Hi @duylong Set it like this:
Leave the i4 Parameter 1 - 4 at default
Choose Root and there the input from which you want to send the On Off command, associate it with the device no endpoint

image

Just done the test and it is working to me, pay attention that both of the Z-Wave devices are included with the same security level.

@duylong
Copy link

duylong commented Feb 27, 2024

I had integrated it in secure mode, thanks for the tip, it's perfect now.

@duylong
Copy link

duylong commented Feb 28, 2024

For information, the association of a Wave i4 in push button mode (momentary switch) with a Wave 1 configured in push button mode (momentary switch) (with an Auto-Off at 1 second) does not seem to work. I have to click several times to get my garage door to react.

Key pressed send an BASIC_SET ON and key released send BASIC_SET OFF ? or Key pressed send an BASIC_SET ON and key pressed again send an BASIC_SET OFF ?

Maybe my usage is not suited to the Wave i4 and I need to use a Wave 1 instead.
In any case I prefer to let you know in case there are improvements to make this pull requests validated.

@QubinoHelp
Copy link
Contributor Author

Hi @duylong

Did you open also a ticket on the Shelly support portal, since I get the same question there ;)

If not, below the answer.

The association is linked to the inputs and will only activate upon pressing the corresponding input button. Sending the command "ON" triggers Wave 1 to turn on and after a set amount of time, it will turn off. Although this is reported to the gateway, it is not reported back to the device that sent the command (i4), so it is unaware that Wave 1 is now off. The i4 believes the last command sent was "ON" and expects the next command to be "OFF". Therefore, pressing the i4 a second time will not affect Wave 1 as it will receive the "OFF" command, and the next press will send the "ON" command again.

Luckily this have nothing to do with the configuration files I've made the pull request, anyhow thanks for letting us know.

Copy link
Member

@AlCalzone AlCalzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I cleaned up the templates a bit, removed some unnecessary fields and restored the QNSH-001P10 file which I had cleaned up when you added it.

@AlCalzone AlCalzone enabled auto-merge (squash) April 4, 2024 15:19
@AlCalzone AlCalzone merged commit 1c11c47 into zwave-js:master Apr 4, 2024
15 checks passed
AlCalzone added a commit that referenced this pull request Apr 4, 2024
### Bugfixes
* Add workaround for devices that omit notification event parameters instead of sending "no data" (#6719)

### Config file changes
* Added 11 Shelly Qubino Wave devices (#6633)
* Add Heatit Leakage Water Stopper (#6605)
* Add Ring Smoke/CO Listener (#6591)
* Add ZVIDAR Z-TRV-V01 thermostatic valve (#6542)
* Add Safe Grow NSG-AB-02 Z-Wave Plus Smart Outlet Plug (#6535)
* Add a new productId and add parameters to 14297/ZW1002 outlet (#6517)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
config ⚙ Configuration issues or updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants