Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(config): modify UltraPro 700 Z-Wave Switch #6601

Closed
wants to merge 48 commits into from
Closed

feat(config): modify UltraPro 700 Z-Wave Switch #6601

wants to merge 48 commits into from

Conversation

apella12
Copy link
Contributor

PR description here:
Added parameters and groups to paddle switch stub item 58433_59344_zw4011.json Merging will close #6578

Added parameters and groups to paddle switch stub item 58433_59344_zw4011.json Merging will close #6578

Signed-off-by: Bob Eckhoff <[email protected]>
@zwave-js-assistant zwave-js-assistant bot added the config ⚙ Configuration issues or updates label Jan 11, 2024
@AlCalzone
Copy link
Member

@jascoproducts, can you please review this?

@apella12
Copy link
Contributor Author

To @jascoproducts
In addition to the PR review, it would be very helpful for us (and therefore your customers) to have some sort of table of product TYPE:ID pairs and their parameters and association groups. For instance there are several "stubs" for your products (0x0063) without that information. Examples (there are several more):

{
	"manufacturer": "Enbrighten",
	"manufacturerId": "0x0063",
	"label": "58436 / 59334 / ZWA4012",
	"description": "In-Wall Toggle Switch, QFSW, 700S",
	"devices": [
		{
			"productType": "0x4952",
			"productId": "0x3330"
		}
	],
	"firmwareVersion": {
		"min": "0.0",
		"max": "255.255"
	}
	// TODO: Add configuration parameters
}
{
	"manufacturer": "Enbrighten",
	"manufacturerId": "0x0063",
	"label": "59335 / 59341 / ZWA3017",
	"description": "In-Wall Toggle Dimmer, QFSW, 700S",
	"devices": [
		{
			"productType": "0x4944",
			"productId": "0x3431"
		}
	],
	"firmwareVersion": {
		"min": "0.0",
		"max": "255.255"
	}
	// TODO: Add configuration parameters
}
{
	"manufacturer": "Enbrighten",
	"manufacturerId": "0x0063",
	"label": "59337 / ZWA4011DV",
	"description": "In-Wall Paddle Switch, 120+277, QFSW, 700S",
	"devices": [
		{
			"productType": "0x4952",
			"productId": "0x3331"
		}
	],
	"firmwareVersion": {
		"min": "0.0",
		"max": "255.255"
	}
	// TODO: Add configuration parameters
}

That way when your customer gets a shiny new device, it will be picked up by Zwave JS and HAss upon inclusion.

Also note that the "stub" for this PR did not include the customer reported Type:ID, so as these are added/changed and the parameters and groups remain the same it would be good to have those too.

Thanks in advance.

AlCalzone and others added 26 commits January 22, 2024 12:39
### Bugfixes
* The check for a changed device config now always returns `false` for the controller (#6625)

### Config file changes
* Disable Supervision for Alfred DB1 Digital Deadbolt Lock to work around battery drain issue (#6629)
* Add 2nd product ID for Ring Panic Button Gen2 (#6595)

### Changes under the hood
* Fix compatibility of ESLint plugin with Node.js 18 (#6580)
### Bugfixes
* Reduce idle CPU load (#6640)

### Config file changes
* Extend version range for Vesternet VES-ZW-DIM-001 (#6636)
### Bugfixes
* NVM backups can now be restored onto 800 series controllers (#6670)

### Config file changes
* Use Color Switch V2 for Inovelli LZW42 (#6654)
* Correct Zooz ZEN1x timer config params (#6648)
Co-authored-by: Jeremy T. Braun <[email protected]>
Co-authored-by: Raman Gupta <[email protected]>
dependabot bot and others added 21 commits April 2, 2024 12:22
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This release adds support for Z-Wave Long Range thanks to the amazing work of @jtbraun. Application developers planning to add support should read [this](https://zwave-js.github.io/node-zwave-js/#/getting-started/long-range) to get started.

### Features
* Support Z-Wave Long Range (#6401, #6620)

### Config file changes
* Remove Association Groups 2 & 3 from AEON Labs DSB09 (#6691)
* Correct group 3 label for GE/Enbrighten 26931/ZW4006 (#6703)
* Add new Fingerprint for Ring Contact sensor (#6676)
* Preserve root endpoint in Vision ZL7432 (#6675)
* Add new Product ID to Fibaro Smoke Detector (#6603)
* Add Product ID for Benext Energy Switch FW1.6 (#6602)
* Add fingerprint for Ring Glass Break Sensor EU (#6590)
* Change MH9-CO2 Temperature Reporting Threshold step size to 0.1 (#6581)
* Add new product ID to Fibaro FGS-213 (#6576)
* Add units, improve descriptions for Everspring ST814 (#6712)
* Label and parameter definitions for Sensative Drip 700 (#6514)
* Override supported sensor scales for HELTUN HE-ZW-THERM-FL2 (#6711)
### Bugfixes
* Fix/improve route diagnostics for Z-Wave LR devices (#6718)
Co-authored-by: Olivier LE LAY <[email protected]>
Co-authored-by: Dominic Griesel <[email protected]>
Co-authored-by: Shelly Qubino Wave Support <[email protected]>
Co-authored-by: Dominic Griesel <[email protected]>
### Bugfixes
* Add workaround for devices that omit notification event parameters instead of sending "no data" (#6719)

### Config file changes
* Added 11 Shelly Qubino Wave devices (#6633)
* Add Heatit Leakage Water Stopper (#6605)
* Add Ring Smoke/CO Listener (#6591)
* Add ZVIDAR Z-TRV-V01 thermostatic valve (#6542)
* Add Safe Grow NSG-AB-02 Z-Wave Plus Smart Outlet Plug (#6535)
* Add a new productId and add parameters to 14297/ZW1002 outlet (#6517)
Added parameters and groups to paddle switch stub item 58433_59344_zw4011.json Merging will close #6578

Signed-off-by: Bob Eckhoff <[email protected]>
@apella12 apella12 closed this Apr 4, 2024
@apella12
Copy link
Contributor Author

apella12 commented Apr 4, 2024

Messed this up trying to rebase

@apella12 apella12 deleted the ge-zwa4011 branch April 4, 2024 18:45
@AlCalzone
Copy link
Member

I often don't bother rebasing anymore, unless it's really clean. Just merge the master branch.

@AlCalzone
Copy link
Member

You should be able to save this with a cherry pick of the relevant commit(s).

@apella12
Copy link
Contributor Author

apella12 commented Apr 4, 2024

I have one more old one, but I'll just leave it. Recreated this #6726. Sorry, I struggle with github.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
config ⚙ Configuration issues or updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UltraPro 700 Series Z-Wave In-Wall Smart Light Switch missing