Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(config): support Comet parameters properly #6583

Merged
merged 5 commits into from
Jul 9, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 49 additions & 0 deletions packages/config/config/devices/0x0148/cometz_700.json
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,23 @@
}
]
},
{
// Some devices report this param, some don't, may be related to firmware version.
// But even when not reported by the device, it is supported.
"#": "6",
"label": "Valve Opening Report Change Threshold",
"valueSize": 1,
"unit": "%",
"minValue": 0,
"maxValue": 100,
"defaultValue": 0,
"options": [
{
"label": "Disabled",
"value": 0
}
]
},
{
"#": "7",
"label": "Open Window Detection",
Expand Down Expand Up @@ -116,6 +133,38 @@
"defaultValue": 0
}
],
"compat": {
"overrideQueries": {
// The device does not report "Manufacturer specific" as a supported thermostat mode
"Thermostat Mode": [
{
"method": "getSupportedModes",
"result": [0, 1, 11, 15, 31], // Off / Heat / Energy heat / Full power / Manufacturer specific
"persistValues": {
"supportedModes": [0, 1, 11, 15, 31]
},
"extendMetadata": {
"thermostatMode": {
"states": {
"0": "Off",
"1": "Heat",
"11": "Energy heat",
"15": "Full power",
"31": "Manufacturer specific"
}
}
}
}
]
},
"commandClasses": {
"remove": {
"Supervision": {
"endpoints": "*"
}
}
}
},
"metadata": {
"manual": "https://eurotronic.org/wp-content/uploads/2023/04/Comet-Z-Wave-EN-2023-04-06.pdf"
}
Expand Down