Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: only expose currentValue on devices that use Basic CC for reporting #6526

Merged
merged 2 commits into from
Nov 30, 2023
Merged

fix: only expose currentValue on devices that use Basic CC for reporting #6526

merged 2 commits into from
Nov 30, 2023

Conversation

AlCalzone
Copy link
Member

Since HA now creates a light entity for devices supporting Basic CC, it was noticed that some sensors that cannot be controlled "support" Basic CC. This is now forbidden per the Z-Wave specifications, so we assume that the devices actually control Basic CC and do not support it. For these devices, Z-Wave JS now only exposes the currentValue:

grafik

fixes: #6516

@AlCalzone
Copy link
Member Author

@zwave-js-bot automerge

@zwave-js-bot zwave-js-bot merged commit b4fb2b5 into master Nov 30, 2023
17 checks passed
@zwave-js-bot zwave-js-bot deleted the basic-sensor branch November 30, 2023 13:02
AlCalzone added a commit that referenced this pull request Nov 30, 2023
@AlCalzone
chore: release v12.4.0
66ad62c 
### Features
* Expose rebuild routes progress as a controller property (#6525)

### Bugfixes
* On devices that should/must not support `Basic CC`, but use it for reporting, only the `currentValue` is now exposed. This allows applications to consider it a sensor, not an actor (#6526)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zwave-js-bot zwave-js-bot zwave-js-bot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ensure Basic CC is NOT supported by sensors
2 participants
@AlCalzone @zwave-js-bot