fix: reopen serial port if controller is missing ACKs after soft-reset #6477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zwave-js-bot automerge |
zwave-js-bot
approved these changes
Oct 31, 2023
AlCalzone
added a commit
that referenced
this pull request
Oct 31, 2023
### Features * Allow disabling the unresponsive controller recovery feature (#6480) ### Bugfixes * Do not abort timed out `Send Data` commands twice (#6484) * Ensure the default Basic CC values are only exposed if they should be, even with the compat `event` enabled (#6485) * Auto-remove failed SmartStart nodes when bootstrapping times out (#6483) * Do not attempt to poll values from nodes that are considered dead (#6470) * Fixed an issue where the send queue was blocked when recovering controller from missed Send Data callback failed (#6473) * Instead of restarting the driver, the serial port is now reopened if controller is still missing ACKs after soft-reset (#6477) * Do not attempt to recover an unresponsive controller before fully initializing (#6480) ### Config file changes * Tweak Heatit Z-TRM6 options (#6464) * Add Ring Alarm Panic Button Gen2 (#6453) * Update fingerprints for Vesternet devices (#6460) ### Changes under the hood * Added a `mock-server` hook to run code after initializing mocks (#6478) * Changed the headline in the logs from "ZWAVE-JS" to "Z-WAVE JS" (#6462) * Lint device config files as part of CI (#6471) * The `enableSoftReset` driver option is now deprecated in favor of `features.softReset` (#6480)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, we no longer restart the driver when the controller does not ACK our commands.
Instead, we now reopen the serial port, hoping that this restarts the controller (at least it should for some 500 series ones). If it doesn't help, we just carry on and hope that the controller recovers itself at some point.
for #6402