fix: preserve stateful and secret flags for dynamic CC values
#6457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zwave-js-bot automerge |
zwave-js-bot
approved these changes
Oct 24, 2023
zwave-js-bot
approved these changes
Oct 24, 2023
AlCalzone
added a commit
that referenced
this pull request
Oct 24, 2023
### Bugfixes * Mark `Central Scene CC` `scene` property as stateless. The previous fix wasn't working. (#6458) * Preserve `stateful` and `secret` flags for dynamic CC values (#6457) ### Config file changes * Correct product id for Fakro ZWS12 (#6454) * add PM-B400ZW-N (#6421) * Ensure `kWh` is written consistently in parameter units (#6456) ### Changes under the hood * Bot: Consider `zwave_js` to be a valid logfile name in issue reports (#6459)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5467 added support for these flags, and made it so they couldn't be overridden by dynamic metadata. However the logic didn't consider that
.optionsis always static, even on dynamic values, while.metaisn't - leading to thestatefulandsecretflags being ignored for dynamic CC values.