fix: populate tone names in metadata for Sound Switch CC defaultToneId
#6452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zwave-js-bot automerge |
zwave-js-bot
approved these changes
Oct 23, 2023
AlCalzone
changed the title
Sound Switch CC defaultToneId
AlCalzone
added a commit
that referenced
this pull request
Oct 24, 2023
### Bugfixes * Fixed an issue where nodes would appear to have two lifeline associations, one with and one without target endpoint 0 (#6448) * Writing to the `volume` value of the `Sound Switch CC` no longer throws an error, but pre-sets the volume to use for the next tone to be played using the `toneId` value (#6450, #6451) * The `defaultToneId` value of the `Sound Switch CC` now also lists the names for each possible tone (#6452) ### Config file changes * Treat `Binary Switch Set` and `Thermostat Mode Set` as reports for `SRT321 HRT4-ZW` (#6423) ### Changes under the hood * Add compat flag to treat `Set` commands as `Report` (#6423)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.