fix: normalize result of Controller.getAvailableFirmwareUpdates to always include channel field
#6359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlCalzone
requested changes
Oct 6, 2023
There was a problem hiding this comment.
I think we should rather normalize the response to always include the channel here:
node-zwave-js/packages/zwave-js/src/lib/controller/FirmwareUpdateService.ts
Lines 226 to 229 in f43abb0
|
good idea, I will adjust this PR accordingly |
raman325
changed the title
AlCalzone
changed the title
Controller.getAvailableFirmwareUpdates to always include channel field
AlCalzone
approved these changes
Oct 9, 2023
AlCalzone
added a commit
that referenced
this pull request
Oct 9, 2023
### Bugfixes * Normalize result of `Controller.getAvailableFirmwareUpdates` to always include `channel` field (#6359) * Fixed a crash that could happen while logging dropped sensor readings (#6379) * Increased the range and default of the `response` timeout to accomodate slower 500 series controllers (#6378) ### Config file changes * Treat Basic Set as events for TKB TZ35S/D and TZ55S/D (#6381) * Add Zooz ZAC38 Range Extender (#6136) * Corrected the label of the notification event `0x0a` to be `Emergency Alarm` (#6368)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The V1 API for the firmware update service doesn't include
channelin the payload so we have to insert it