Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(config): add Qubino Shades Remote Controller #6335

Merged
merged 1 commit into from
Oct 11, 2023
Merged

feat(config): add Qubino Shades Remote Controller #6335

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions packages/config/config/devices/0x015a/jtb-zmnkgd1.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
{
"manufacturer": "Jin Tao Bao",
"manufacturerId": "0x015a",
"label": "JTB-ZMNKGD1",
Comment on lines +2 to +4
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@QubinoHelp I assume this is the manufacturer that produced this device for you?
We typically put the brand name in the manufacturer field, so should this be changed to Qubino, or is this one of those white-label devices that's sold under multiple brands?

Copy link
Contributor

@QubinoHelp QubinoHelp Sep 29, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes they produce the remotes for us. I suppose it can be added under multiple brands.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok then we'll have to leave this as-is.

"description": "Shades Remote Controller",
"devices": [
{
"productType": "0x2000",
"productId": "0x0003"
}
],
"firmwareVersion": {
"min": "0.0",
"max": "255.255"
}
}