Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add wave 1pm #6308

Closed
wants to merge 27 commits into from
Closed

fix: add wave 1pm #6308

wants to merge 27 commits into from

Conversation

QubinoHelp
Copy link
Contributor

fix: updated prameter descriptions, removed double 23 parameter

zwave-js-bot and others added 27 commits September 13, 2023 12:37
@zwave-js-bot
feat(config): import config files from zwa
bdc916b
@QubinoHelp @AlCalzone
Update qnsw-001x16.json
884cf5b 
- updated label
- updated description (product name)
- corrected the productType & productId
- added parameter descriptions
@QubinoHelp @AlCalzone
Update qnsw-001x16.json
aba8a4a 
- added name manufacturer
- corrected Label & description
- removed zwaveAllianceId (do not have one yet)
- added parameters description and options
@QubinoHelp @AlCalzone
Update qnsw-001x16.json
4c37506 
- added read only state to parameter 201, 202, 203
@QubinoHelp @AlCalzone
Rename qnsw-001x16.json to qnsw-001P16.json
2efc565 
- rename the file
@QubinoHelp @AlCalzone
Update qnsw-001P16.json
ce01641
@QubinoHelp @AlCalzone
Update packages/config/config/devices/0x0460/qnsw-001P16.json
c31d52f 
Co-authored-by: AlCalzone <[email protected]>
@QubinoHelp @AlCalzone
Update packages/config/config/devices/0x0460/qnsw-001P16.json
e288e5c 
Co-authored-by: AlCalzone <[email protected]>
@QubinoHelp @AlCalzone
Update packages/config/config/devices/0x0460/qnsw-001P16.json
e5eccea 
Co-authored-by: AlCalzone <[email protected]>
@QubinoHelp @AlCalzone
Update packages/config/config/devices/0x0460/qnsw-001P16.json
a1c040f 
Co-authored-by: AlCalzone <[email protected]>
@QubinoHelp @AlCalzone
Update packages/config/config/devices/0x0460/qnsw-001P16.json
eafec8f 
Co-authored-by: AlCalzone <[email protected]>
@QubinoHelp @AlCalzone
Update packages/config/config/devices/0x0460/qnsw-001P16.json
05ab129 
Co-authored-by: AlCalzone <[email protected]>
@QubinoHelp @AlCalzone
Update packages/config/config/devices/0x0460/qnsw-001P16.json
5b083bd 
Co-authored-by: AlCalzone <[email protected]>
@QubinoHelp @AlCalzone
Update packages/config/config/devices/0x0460/qnsw-001P16.json
f4544bf 
Co-authored-by: AlCalzone <[email protected]>
@QubinoHelp @AlCalzone
Update packages/config/config/devices/0x0460/qnsw-001P16.json
beb778c 
Co-authored-by: AlCalzone <[email protected]>
@QubinoHelp @AlCalzone
Update packages/config/config/devices/0x0460/qnsw-001P16.json
47bb118 
Co-authored-by: AlCalzone <[email protected]>
@QubinoHelp @AlCalzone
Update packages/config/config/devices/0x0460/qnsw-001P16.json
14c0669 
Co-authored-by: AlCalzone <[email protected]>
@QubinoHelp @AlCalzone
Update packages/config/config/devices/0x0460/qnsw-001P16.json
b724e6b 
Co-authored-by: AlCalzone <[email protected]>
@QubinoHelp @AlCalzone
Update packages/config/config/devices/0x0460/qnsw-001P16.json
e195e06 
Co-authored-by: AlCalzone <[email protected]>
@QubinoHelp @AlCalzone
Update packages/config/config/devices/0x0460/qnsw-001P16.json
76d7059 
Co-authored-by: AlCalzone <[email protected]>
@QubinoHelp @AlCalzone
Update packages/config/config/devices/0x0460/qnsw-001P16.json
5372d36 
Co-authored-by: AlCalzone <[email protected]>
@QubinoHelp @AlCalzone
Update packages/config/config/devices/0x0460/qnsw-001P16.json
b29275d 
Co-authored-by: AlCalzone <[email protected]>
@AlCalzone
fix: formatting
1232f3b
@AlCalzone
fix: some labels
31e6e70
@AlCalzone
fix: descriptions, consistency
49f7e30
fix: merge problems
f13291b
fix: double 23 parameter removed one
709d1c9
@zwave-js-assistant zwave-js-assistant bot added the config ⚙ Configuration issues or updates label Sep 22, 2023
@AlCalzone
Copy link
Member

@QubinoHelp I think you just did minimal changes, but this looks like the entire file was changed.
The original PR was merged, so any further changes need to be based off the master branch. To do so,

  1. make sure your copy of the branch is up to date: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork
  2. create a new branch in your repository, based on the up-to-date master branch
  3. make your changes there, then
  4. create a pull request from that branch.

@QubinoHelp QubinoHelp closed this Sep 25, 2023
@QubinoHelp QubinoHelp deleted the import-config-1694608670 branch September 25, 2023 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
config ⚙ Configuration issues or updates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@QubinoHelp @AlCalzone @zwave-js-bot