Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(config): Wave 1PM config file #6307

Closed
wants to merge 27 commits into from
Closed

fix(config): Wave 1PM config file #6307

wants to merge 27 commits into from

Conversation

QubinoHelp
Copy link
Contributor

fix: updated and correct parameters descriptions, removed double parameter 23

zwave-js-bot and others added 27 commits September 13, 2023 12:37
- updated label
- updated description (product name)
- corrected the productType & productId
- added parameter descriptions
- added name manufacturer
- corrected Label & description
- removed zwaveAllianceId (do not have one yet)
- added parameters description and options
- added read only state to parameter 201, 202, 203
@zwave-js-assistant zwave-js-assistant bot added the config ⚙ Configuration issues or updates label Sep 22, 2023
@zwave-js-assistant
Copy link

💡 The pull request title does not match our guidelines 💡

We follow conventional commits, check out the description and examples. This means that the PR title must...

  • start with the type of change, e.g. feat:, or fix:
  • optionally specify a scope, for example we use config for changes to config files: feat(config):
  • contain a description that explains what is being changed, e.g. add a parameter, correct a typo, ...
  • and ideally explains what the change affects, e.g. the device (manufacturer, device label, firmware, ...)

The description should use uppercase and lowercase normally, except for the first character which must be lowercase.

@QubinoHelp QubinoHelp closed this Sep 22, 2023
@QubinoHelp QubinoHelp deleted the import-config-1694608670 branch September 25, 2023 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
config ⚙ Configuration issues or updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants