fix: attempt soft-resetting controller when callback times out #6296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zwave-js-bot automerge |
zwave-js-bot
approved these changes
Sep 21, 2023
AlCalzone
added a commit
that referenced
this pull request
Sep 22, 2023
### Bugfixes * A bug in the `7.19.x` SDK has surfaced where the controller gets stuck in the middle of a transmission. Previously this would go unnoticed because the failed commands would cause the nodes to be marked dead until the controller finally recovered. Since `v11.12.0` however, Z-Wave JS would consider the controller jammed and retry the last command indefinitely. This situation is now detected and Z-Wave JS attempts to recover by soft-resetting the controller when this happens. (#6296) ### Config file changes * Add Shelly Wave 1PM (#6280) ### Changes under the hood * Migrated more Z-Wave JS specific checks to the custom ESLint plugin (#6297, #6302)
AlCalzone
added a commit
that referenced
this pull request
Sep 26, 2023
### Breaking changes · [Migration guide](https://zwave-js.github.io/node-zwave-js/#/getting-started/migrating-to-v12) * Remove support for Node.js 14 and 16 (#6245) * Subpath exports are now exposed using the `exports` field in `package.json` instead of `typesVersions` (#5839) * The `"notification"` event now includes a reference to the endpoint that sent the notification (#6083) * Keep separate Supervision session ID counters for each node (#6175) * Validate the device fingerprint before installing firmware update instead of when checking for updates (#6192) * Removed some deprecated methods (#6250) * Managing SUC routes with the non-SUC method variants is no longer allowed (#6251) * "Heal (network)" was renamed to "rebuild routes" to better reflect what it does (#6252) * Corrected the argument type for `Driver.constructor`, `updateLogConfig` and `updateOptions` (#6254, #6319) ### Features * Detect an unresponsive stick and reset it (#6244) * The default time after which battery-powered devices with no pending commands are sent back to sleep is now `250 ms` (down from `1000ms`). This timeout is now configurable using the driver option `timeouts.sendToSleep`. This should result in significant battery savings for devices that frequently wake up. (#6312) ### Bugfixes * A bug in the `7.19.x` SDK has surfaced where the controller gets stuck in the middle of a transmission. Previously this would go unnoticed because the failed commands would cause the nodes to be marked dead until the controller finally recovered. Since `v11.12.0` however, Z-Wave JS would consider the controller jammed and retry the last command indefinitely. This situation is now detected and Z-Wave JS attempts to recover by soft-resetting the controller when this happens. (#6296) * Removed auto-disabling of soft-reset capability (#6256) * Default to RF protection state `Unprotected` if not given for `Protection CC` V2+ (#6257) ### Config file changes * Add Heatit Z-Water 2 (#6299) * Add Shelly Wave 1PM (#6280, #6317) * Add Heatit Z-TRM6 (#6263) * Increase poll delay for ZW500D (#6270) * Add fingerprint for Simon IO Master Roller Blind (#6262) * Add HOPPE eHandle ConnectSense (#6269) * Add parameters to Zooz ZEN17 from firmware 1.30 (#6189) * Update Zooz ZEN32 config to the latest firmware, include 800 series (#6283) ### Changes under the hood * Fixed the interpretation of `limit_options` in OpenSmartHouse import script (#6313) * Some Z-Wave JS specific implementation checks are now done using a custom ESLint plugin (#6276, #6279, #6315) * Migrated more Z-Wave JS specific checks to the custom ESLint plugin (#6297, #6302) * Use ESLint to enforce consistent property ordering in config parameters and avoid unnecessary `minValue/maxValue` (#6321, #6322) * `yarn test` now only runs tests affected by changed files by default. This is also done on CI in PRs to speed up check times (#6274) * Upgraded lots of dependencies (#6258)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a workaround for controllers that get stuck while transmitting and never respond with the SendData callback. According to the Serial API specs, this
but it has recently started happening frequently on the 7.19.x firmware line. Turns out that just aborting the transmission isn't enough to recover. As a result, we now use the existing recovery mechanism for missing ACKs from an unresponsive controller and destroy the driver when soft-resetting isn't enough.
fixes: #6260 (hopefully)