fix: flaky test

zwave-js · Nov 5, 2024 · d1c5115 · d1c5115
1 parent ab5676b
commit d1c5115
Showing 1 changed file with 10 additions and 2 deletions.
diff --git a/packages/zwave-js/src/lib/driver/Task.test.ts b/packages/zwave-js/src/lib/driver/Task.test.ts
@@ -1109,9 +1109,12 @@ test("Tasks can be removed while running", async (t) => {
 	const order: string[] = [];
 	scheduler.start();
 
+	const t1WasStarted = createDeferredPromise<void>();
+
 	const task1 = scheduler.queueTask({
 		priority: TaskPriority.Normal,
 		task: async function*() {
+			t1WasStarted.resolve();
 			order.push("1a");
 			await wait(10);
 			yield;
@@ -1137,7 +1140,7 @@ test("Tasks can be removed while running", async (t) => {
 		},
 	});
 
-	await wait(1);
+	await t1WasStarted;
 	// Task 1 should have run to the first yield,
 	// Task 2 should not have started yet
 	t.expect(order).toStrictEqual(["1a"]);
@@ -1160,9 +1163,13 @@ test("Tasks can be removed while running and paused", async (t) => {
 	const order: string[] = [];
 	scheduler.start();
 
+	const t1WasStarted = createDeferredPromise<void>();
+	const t2WasStarted = createDeferredPromise<void>();
+
 	const task1 = scheduler.queueTask({
 		priority: TaskPriority.Normal,
 		task: async function*() {
+			t1WasStarted.resolve();
 			order.push("1a");
 			yield () => wait(10);
 			order.push("1b");
@@ -1177,6 +1184,7 @@ test("Tasks can be removed while running and paused", async (t) => {
 		name: "task2",
 		priority: TaskPriority.Normal,
 		task: async function*() {
+			t2WasStarted.resolve();
 			order.push("2a");
 			await wait(10);
 			yield;
@@ -1188,7 +1196,7 @@ test("Tasks can be removed while running and paused", async (t) => {
 		},
 	});
 
-	await wait(1);
+	await Promise.all([t1WasStarted, t2WasStarted]);
 	// Both tasks should have run to the first yield.
 	t.expect(order).toStrictEqual(["1a", "2a"]);