fix: move workaround for 500 series controller bug to master template…

…, enable for Zooz ZST10 (#6372)
zwave-js · Oct 5, 2023 · 9d4316e · 9d4316e
1 parent ae9a87b
commit 9d4316e
Show file tree

Hide file tree

Showing 4 changed files with 18 additions and 12 deletions.
diff --git a/packages/config/config/devices/0x0000/husbzb-1.json b/packages/config/config/devices/0x0000/husbzb-1.json
@@ -14,11 +14,7 @@
 		"max": "255.255"
 	},
 	"compat": {
-		// In some situations, AssignSUCReturnRoute and DeleteSUCReturnRoute get answered with a wrong callback function type,
-		// triggering Z-Wave JS's unresponsive controller check.
-		"disableCallbackFunctionTypeCheck": [
-			81, // AssignSUCReturnRoute
-			85 // DeleteSUCReturnRoute
-		]
+		// Workaround for a firmware bug in 500 series controllers
+		"$import": "~/templates/master_template.json#500_series_controller_compat_flags"
 	}
 }
diff --git a/packages/config/config/devices/0x0086/zw090.json b/packages/config/config/devices/0x0086/zw090.json
@@ -60,11 +60,7 @@
 		"manual": "https://products.z-wavealliance.org/ProductManual/File?folder=&filename=MarketCertificationFiles/1345/Z%20Stick%20Gen5%20manual%201.pdf"
 	},
 	"compat": {
-		// In some situations, AssignSUCReturnRoute and DeleteSUCReturnRoute get answered with a wrong callback function type,
-		// triggering Z-Wave JS's unresponsive controller check.
-		"disableCallbackFunctionTypeCheck": [
-			81, // AssignSUCReturnRoute
-			85 // DeleteSUCReturnRoute
-		]
+		// Workaround for a firmware bug in 500 series controllers
+		"$import": "~/templates/master_template.json#500_series_controller_compat_flags"
 	}
 }
diff --git a/packages/config/config/devices/0x027a/zst10.json b/packages/config/config/devices/0x027a/zst10.json
@@ -12,5 +12,9 @@
 	"firmwareVersion": {
 		"min": "0.0",
 		"max": "255.255"
+	},
+	"compat": {
+		// Workaround for a firmware bug in 500 series controllers
+		"$import": "~/templates/master_template.json#500_series_controller_compat_flags"
 	}
 }
diff --git a/packages/config/config/devices/templates/master_template.json b/packages/config/config/devices/templates/master_template.json
@@ -675,5 +675,15 @@
 				"text": "Firmware version 7.19.3 has a bug that causes the controller to randomly hang during transmission until it is restarted. It is currently unclear if this bug is fixed in a later firmware version."
 			}
 		]
+	},
+	"500_series_controller_compat_flags": {
+		// It seems that all 500 series controllers have a firmware bug:
+
+		// When failing, AssignSUCReturnRoute and DeleteSUCReturnRoute get answered with a wrong callback function type,
+		// triggering Z-Wave JS's unresponsive controller check.
+		"disableCallbackFunctionTypeCheck": [
+			81, // AssignSUCReturnRoute
+			85 // DeleteSUCReturnRoute
+		]
 	}
 }