Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix fromSelf always being truthy #9

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

itswillta
Copy link
Contributor

@itswillta itswillta commented Aug 18, 2024

Linked issue: #8.

@itswillta itswillta force-pushed the fromSelf-always-truthy branch from 7a40c64 to 243491d Compare August 18, 2024 13:14
Copy link

codesandbox-ci bot commented Aug 18, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

src/index.ts Outdated Show resolved Hide resolved
@itswillta itswillta force-pushed the fromSelf-always-truthy branch from 243491d to d1dfd1b Compare August 18, 2024 14:09
@itswillta itswillta requested review from dai-shi August 18, 2024 14:12
Copy link
Member

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Can you check the CI error please?

@itswillta itswillta force-pushed the fromSelf-always-truthy branch from d1dfd1b to 122c84d Compare August 19, 2024 05:51
Copy link
Member

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@dai-shi dai-shi merged commit 1c32e78 into zustandjs:main Aug 19, 2024
2 checks passed
@dai-shi dai-shi mentioned this pull request Aug 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants