Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated cpp version to 17 #163

Merged
merged 19 commits into from
May 12, 2024
Merged

updated cpp version to 17 #163

merged 19 commits into from
May 12, 2024

Conversation

zussel
Copy link
Owner

@zussel zussel commented May 1, 2024

#157 removed occurrences of matador::any and matador::optional and replaced it with std::variant

…tador::optional and replaced it with std::variant
@zussel zussel added this to the Matador 0.9.3 (Gorstian) milestone May 1, 2024
@zussel zussel self-assigned this May 1, 2024
Copy link

codecov bot commented May 2, 2024

Codecov Report

Attention: Patch coverage is 85.51136% with 51 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (develop@8256f2e). Click here to learn what that means.

Files Patch % Lines
include/matador/sql/value_processor.hpp 74.41% 11 Missing ⚠️
include/matador/utils/convert.hpp 80.00% 8 Missing ⚠️
src/sql/value.cpp 85.45% 8 Missing ⚠️
src/sql/value_processor.cpp 81.81% 6 Missing ⚠️
src/utils/convert.cpp 80.00% 6 Missing ⚠️
src/sql/column.cpp 0.00% 3 Missing ⚠️
include/matador/sql/column_value_visitor.hpp 89.47% 2 Missing ⚠️
include/matador/sql/memory_connection.hpp 0.00% 1 Missing ⚠️
...clude/matador/sql/query_value_column_processor.hpp 94.73% 1 Missing ⚠️
src/db/mssql/mssql_connection.cpp 0.00% 1 Missing ⚠️
... and 4 more
Additional details and impacted files
@@            Coverage Diff             @@
##             develop     #163   +/-   ##
==========================================
  Coverage           ?   85.78%           
==========================================
  Files              ?      342           
  Lines              ?    14468           
  Branches           ?        0           
==========================================
  Hits               ?    12412           
  Misses             ?     2056           
  Partials           ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zussel zussel merged commit 286c50f into develop May 12, 2024
6 checks passed
@zussel zussel mentioned this pull request May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant