Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui: Rename "All messages" to "Combined feed". #644

Merged
merged 1 commit into from
May 14, 2024
Merged

ui: Rename "All messages" to "Combined feed". #644

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions assets/l10n/app_en.arb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -460,9 +460,9 @@
"@recentDmConversationsPageTitle": {
"description": "Title for the page of recent DM conversations"
},
"allMessagesPageTitle": "All messages",
"@allMessagesPageTitle": {
"description": "Title for the page of all messages"
"combinedFeedPageTitle": "Combined feed",
"@combinedFeedPageTitle": {
"description": "Title for the page of combined feed."
},
"notifGroupDmConversationLabel": "{senderFullName} to you and {numOthers, plural, =1{1 other} other{{numOthers} others}}",
"@notifGroupDmConversationLabel": {
Expand Down
2 changes: 1 addition & 1 deletion lib/widgets/app.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,7 @@ class HomePage extends StatelessWidget {
onPressed: () => Navigator.push(context,
MessageListPage.buildRoute(context: context,
narrow: const AllMessagesNarrow())),
child: Text(zulipLocalizations.allMessagesPageTitle)),
child: Text(zulipLocalizations.combinedFeedPageTitle)),
const SizedBox(height: 16),
ElevatedButton(
onPressed: () => Navigator.push(context,
Expand Down
2 changes: 1 addition & 1 deletion lib/widgets/message_list.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ class MessageListAppBarTitle extends StatelessWidget {

switch (narrow) {
case AllMessagesNarrow():
return Text(zulipLocalizations.allMessagesPageTitle);
return Text(zulipLocalizations.combinedFeedPageTitle);

case StreamNarrow(:var streamId):
final store = PerAccountStoreWidget.of(context);
Expand Down
Loading