Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from the deprecated and removed APIs #109

Merged
merged 2 commits into from
Oct 12, 2023

Conversation

tisonkun
Copy link
Contributor

@tisonkun tisonkun commented Oct 3, 2023

The old API is removed in Py 3.12 and in entrypoint.sh we always use the latest Py version.

@tisonkun
Copy link
Contributor Author

tisonkun commented Oct 3, 2023

cc @rht This can fail all the downstream workflows.

Signed-off-by: tison <[email protected]>
@i-ky
Copy link
Contributor

i-ky commented Oct 3, 2023

cc @rht This can fail all the downstream workflows.

Not only can, but actually does fail downstream workflows. Please address the issue as soon as possible.

@rht
Copy link
Contributor

rht commented Oct 3, 2023

LGTM @timabbott

@i-ky i-ky mentioned this pull request Oct 3, 2023
@i-ky
Copy link
Contributor

i-ky commented Oct 3, 2023

I filed #110 with a less risky change, which can be applied ASAP to fix failing workflows. Python 3.12 compatibility can be addressed with less stress after that.

@timabbott
Copy link
Member

OK, do we still need this given #110 is integrated?

@i-ky
Copy link
Contributor

i-ky commented Oct 4, 2023

OK, do we still need this given #110 is integrated?

I would say yes, because you cannot stay on 3.11 forever. Eventually (in October 2027 it will reach end-of-life and staying on 3.11 further will have security implications.

#110 affects this PR in two ways:

  1. there is no more pressure to integrate the fix ASAP, you have plenty of time to decide if this is the best way to move away from the deprecated functionality (I am not competent enough to judge this aspect);
  2. the pinned Python version in Dockerfile needs to be bumped to 3.12.

@timabbott timabbott merged commit 0d21375 into zulip:master Oct 12, 2023
2 checks passed
@timabbott
Copy link
Member

Merged, thanks @i-ky and @tisonkun!

@tisonkun tisonkun deleted the py12-compat branch October 12, 2023 18:47
@i-ky
Copy link
Contributor

i-ky commented Oct 13, 2023

2. the pinned Python version in Dockerfile needs to be bumped to 3.12.

Now this can be done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants