Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change manifest.json path for vite 5.0 #147

Closed
wants to merge 1 commit into from
Closed

Conversation

tsnobip
Copy link
Contributor

@tsnobip tsnobip commented Jan 17, 2024

manifest.json default path got moved into a .vite folder cf vitejs/vite#14230

manifest.json default path got moved into a .vite folder
cf vitejs/vite#14230
@zth
Copy link
Owner

zth commented Jan 31, 2024

@tsnobip sorry, missed this! We need to upgrade Vite versions of the router here as well, right?

@tsnobip
Copy link
Contributor Author

tsnobip commented Jan 31, 2024

@tsnobip sorry, missed this! We need to upgrade Vite versions of the router here as well, right?

yes, sorry for the half-baked PR, you need to upgrade vite to v5 too, otherwise it won't work.

I just did it as a reminder because I got bitten by this and I knew you would too eventually once you'd upgrade vite.

@zth
Copy link
Owner

zth commented Jul 21, 2024

I've upgraded Vite to 5.x now, and moved the server stuff into its own Vite plugin. We can continue fixing these things whenever we go back to solving server stuff.

@zth zth closed this Jul 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants