Add the manufacturer code to the ZclAttributeDao #994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This field has previously been missing in the DAO, but should be stored in the database as well. Signed-off-by: Henning Sudbrock <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #994 +/- ##
============================================
+ Coverage 30.3% 30.31% +<.01%
- Complexity 4028 4030 +2
============================================
Files 1424 1424
Lines 55233 55238 +5
Branches 2445 2445
============================================
+ Hits 16739 16746 +7
+ Misses 37765 37763 -2
Partials 729 729
Continue to review full report at Codecov.
|
|
Thanks Henning. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This field has previously been missing in the
ZclAttributeDao, but should be storedin the database as well.
What does go wrong without this fix? After re-filling the node list from the database, operations like, e.g., attribute reads for manufacturer-specific attributes will fail because the manufacturer-specific bit will not be set in the requests anymore.
Chris, this is one of the issues that we discussed in #989.
Signed-off-by: Henning Sudbrock [email protected]