Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Ember TC link policy to not generate new keys #703

Merged
merged 1 commit into from
Aug 12, 2019

Conversation

cdjackson
Copy link
Member

This prevents the Ember dongle generating a new key and adding it to the key table when a device requests the key. If this is allowed, then the application must ensure that when the device leaves and rejoins, a new transient key is used, or the keytable has this entry removed or the device will not rejoin.

#701

Signed-off-by: Chris Jackson [email protected]

@cdjackson cdjackson added the EMBER label Aug 9, 2019
@codecov
Copy link

codecov bot commented Aug 9, 2019

Codecov Report

Merging #703 into master will increase coverage by <.01%.
The diff coverage is 61.9%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #703      +/-   ##
============================================
+ Coverage     27.87%   27.87%   +<.01%     
  Complexity     3534     3534              
============================================
  Files          1365     1365              
  Lines         49007    49022      +15     
  Branches       2116     2116              
============================================
+ Hits          13659    13667       +8     
- Misses        34723    34729       +6     
- Partials        625      626       +1
Impacted Files Coverage Δ Complexity Δ
.../dongle/ember/ezsp/structure/EmberCounterType.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...ee/dongle/ember/ezsp/structure/EmberKeyStatus.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...igbee/dongle/ember/ezsp/structure/EzspValueId.java 94.91% <100%> (+0.68%) 4 <0> (ø) ⬇️
...ee/dongle/ember/ezsp/structure/EzspDecisionId.java 89.18% <100%> (+0.3%) 3 <0> (ø) ⬇️
...tsystems/zigbee/dongle/ember/ZigBeeDongleEzsp.java 50.42% <100%> (+0.1%) 46 <0> (ø) ⬇️
.../zigbee/app/discovery/ZigBeeNetworkDiscoverer.java 77.24% <0%> (-0.53%) 18% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 669978c...903b023. Read the comment docs.

@cdjackson cdjackson merged commit 7a0eb4c into master Aug 12, 2019
@cdjackson cdjackson deleted the ember_link_key_policy branch August 12, 2019 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant