Only restore attribute state from the node database for non-manufacturer-specific attributes #1001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manufacturer-specific attributes This resolves zsmartsystems#989 and zsmartsystems#236. Signed-off-by: Henning Sudbrock <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1001 +/- ##
=========================================
Coverage 30.32% 30.33%
- Complexity 4032 4035 +3
=========================================
Files 1424 1424
Lines 55238 55242 +4
Branches 2445 2446 +1
=========================================
+ Hits 16750 16755 +5
+ Misses 37759 37757 -2
- Partials 729 730 +1
Continue to review full report at Codecov.
|
|
Thanks Henning. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #989 and #236.
With this change, when restoring a cluster from a
ZclClusterDaoobtained from the node database, for non-manufacturer-specific attributes only the dynamic attribute state will be restored (i.e., last value, last reporting time, and whether the attribute was marked as implemented).The benefit is that changes in the attribute definition in the
Zcl***Clusterclasses generated by the autocoder will be applied to attributes, even when the information stored in the node database is from before those changes were made. (E.g., when adding new attributes as described in #236, or when fixing datatypes as described in #989.)