Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Release v3.0.0 OneAPI Upgrade #288

Open
wants to merge 20 commits into
base: master
Choose a base branch
from

Conversation

willguibr
Copy link
Member

@willguibr willguibr commented Dec 5, 2024

Provide a general summary of your changes in the title above. You should
remove this overview, any sections and any section descriptions you
don't need below before submitting. There isn't a strict requirement to
use this template if you can structure your description and still cover
these points.

Description

Describe your changes in detail through motivation and context. Why is
this change required? What problem does it solve? If it fixes an open
issue, link to the issue using GitHub's closing issues keywords1.

Has your change been tested?

Explain how the change has been tested and what you ran to confirm your
change affects other parts of the code. Automated tests are generally
expected and changes without tests should explain why they aren't
required.

Screenshots (if appropriate):

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented and stable APIs.

Copy link

codecov bot commented Dec 5, 2024

Codecov Report

Attention: Patch coverage is 37.73350% with 500 lines in your changes missing coverage. Please review.

Project coverage is 33.14%. Comparing base (016cbb7) to head (eff1af3).

Files with missing lines Patch % Lines
zscaler/zcon/v2_client.go 40.45% 333 Missing and 57 partials ⚠️
...aler/zcon/services/activation_cli/zconActivator.go 0.00% 50 Missing ⚠️
...ervices/adminuserrolemgmt/adminroles/adminroles.go 22.22% 14 Missing ⚠️
...ervices/adminuserrolemgmt/adminusers/adminusers.go 28.57% 10 Missing ⚠️
...n/services/locationmanagement/location/location.go 33.33% 8 Missing ⚠️
...con/services/provisioning/api_keys/provisioning.go 0.00% 8 Missing ⚠️
...oning/public_cloud_account/public_cloud_account.go 0.00% 8 Missing ⚠️
zscaler/zcon/services/ecgroup/ecgroup.go 50.00% 6 Missing ⚠️
...es/locationmanagement/locationlite/locationlite.go 0.00% 4 Missing ⚠️
zscaler/zcon/services/common/common.go 50.00% 2 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (016cbb7) and HEAD (eff1af3). Click for more details.

HEAD has 244 uploads less than BASE
Flag BASE (016cbb7) HEAD (eff1af3)
263 19
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #288       +/-   ##
===========================================
- Coverage   49.82%   33.14%   -16.69%     
===========================================
  Files         179       17      -162     
  Lines        8692     1394     -7298     
===========================================
- Hits         4331      462     -3869     
+ Misses       3855      846     -3009     
+ Partials      506       86      -420     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@willguibr willguibr temporarily deployed to ZCON_ZSCALER_BETA December 16, 2024 17:49 — with GitHub Actions Inactive
@willguibr willguibr temporarily deployed to ZCON_ZSCALER_THREE December 16, 2024 17:50 — with GitHub Actions Inactive
@willguibr willguibr changed the title feat: Release v4.0.0 OneAPI Upgrade feat: Release v3.0.0 OneAPI Upgrade Dec 18, 2024
@willguibr willguibr added enhancement New feature or request language/go Pull requests that update Go code zpa-new-attributes ZPA API Added New Parameters ZIA New API Resources ZIA New API Resources new-acceptance-tests New acceptance tests ZPA New API Resources ZPA New API Resources ZCON New API Resources Zscaler Branch & Cloud Connector Resource ZDX New API Resources ZDX New API Resources go Pull requests that update Go code In development Under active development zia-new-attributes ZIA API Added New Parameters labels Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request go Pull requests that update Go code In development Under active development language/go Pull requests that update Go code new-acceptance-tests New acceptance tests ZCON New API Resources Zscaler Branch & Cloud Connector Resource ZDX New API Resources ZDX New API Resources ZIA New API Resources ZIA New API Resources zia-new-attributes ZIA API Added New Parameters ZPA New API Resources ZPA New API Resources zpa-new-attributes ZPA API Added New Parameters
Projects
Status: ⚙️ In development
Development

Successfully merging this pull request may close these issues.

1 participant