Merge pull request #197 from zscaler/zia-#196-more-integration-tests

fix: Included additional zia and zpa integration tests
zscaler · Dec 8, 2023 · 5df060e · 5df060e
2 parents 151d3e9 + 94dbe21
commit 5df060e
Show file tree

Hide file tree

Showing 53 changed files with 1,787 additions and 942 deletions.
diff --git a/zia/services/adminuserrolemgmt/admins/admin_users_test.go b/zia/services/adminuserrolemgmt/admins/admin_users_test.go
@@ -263,3 +263,55 @@ func tryRetrieveResource(s *Service, id int) (*AdminUsers, error) {
 
 	return nil, err
 }
+
+func TestRetrieveNonExistentResource(t *testing.T) {
+	client, err := tests.NewZiaClient()
+	if err != nil {
+		t.Fatalf("Error creating client: %v", err)
+	}
+	service := New(client)
+
+	_, err = service.GetAdminUsers(0)
+	if err == nil {
+		t.Error("Expected error retrieving non-existent resource, but got nil")
+	}
+}
+
+func TestDeleteNonExistentResource(t *testing.T) {
+	client, err := tests.NewZiaClient()
+	if err != nil {
+		t.Fatalf("Error creating client: %v", err)
+	}
+	service := New(client)
+
+	_, err = service.DeleteAdminUser(0)
+	if err == nil {
+		t.Error("Expected error deleting non-existent resource, but got nil")
+	}
+}
+
+func TestUpdateNonExistentResource(t *testing.T) {
+	client, err := tests.NewZiaClient()
+	if err != nil {
+		t.Fatalf("Error creating client: %v", err)
+	}
+	service := New(client)
+
+	_, err = service.UpdateAdminUser(0, AdminUsers{})
+	if err == nil {
+		t.Error("Expected error updating non-existent resource, but got nil")
+	}
+}
+
+func TestGetByNameNonExistentResource(t *testing.T) {
+	client, err := tests.NewZiaClient()
+	if err != nil {
+		t.Fatalf("Error creating client: %v", err)
+	}
+	service := New(client)
+
+	_, err = service.GetAdminByUsername("non-existent-name")
+	if err == nil {
+		t.Error("Expected error retrieving resource by non-existent name, but got nil")
+	}
+}
diff --git a/zia/services/dlp_engines/dlp_engines.go → zia/services/dlp/dlp_engines/dlp_engines.go b/zia/services/dlp_engines/dlp_engines.go → zia/services/dlp/dlp_engines/dlp_engines.go
diff --git a/zia/services/dlp_engines/dlp_engines_test.go → ...vices/dlp/dlp_engines/dlp_engines_test.go b/zia/services/dlp_engines/dlp_engines_test.go → ...vices/dlp/dlp_engines/dlp_engines_test.go
@@ -215,3 +215,55 @@ func tryRetrieveResource(s *Service, id int) (*DLPEngines, error) {
 
 	return nil, err
 }
+
+func TestRetrieveNonExistentResource(t *testing.T) {
+	client, err := tests.NewZiaClient()
+	if err != nil {
+		t.Fatalf("Error creating client: %v", err)
+	}
+	service := New(client)
+
+	_, err = service.Get(0)
+	if err == nil {
+		t.Error("Expected error retrieving non-existent resource, but got nil")
+	}
+}
+
+func TestDeleteNonExistentResource(t *testing.T) {
+	client, err := tests.NewZiaClient()
+	if err != nil {
+		t.Fatalf("Error creating client: %v", err)
+	}
+	service := New(client)
+
+	_, err = service.Delete(0)
+	if err == nil {
+		t.Error("Expected error deleting non-existent resource, but got nil")
+	}
+}
+
+func TestUpdateNonExistentResource(t *testing.T) {
+	client, err := tests.NewZiaClient()
+	if err != nil {
+		t.Fatalf("Error creating client: %v", err)
+	}
+	service := New(client)
+
+	_, _, err = service.Update(0, &DLPEngines{})
+	if err == nil {
+		t.Error("Expected error updating non-existent resource, but got nil")
+	}
+}
+
+func TestGetByNameNonExistentResource(t *testing.T) {
+	client, err := tests.NewZiaClient()
+	if err != nil {
+		t.Fatalf("Error creating client: %v", err)
+	}
+	service := New(client)
+
+	_, err = service.GetByName("non-existent-name")
+	if err == nil {
+		t.Error("Expected error retrieving resource by non-existent name, but got nil")
+	}
+}
diff --git a/zia/services/dlp_engines/service.go → zia/services/dlp/dlp_engines/service.go b/zia/services/dlp_engines/service.go → zia/services/dlp/dlp_engines/service.go
diff --git a/..._exact_data_match/dlp_exact_data_match.go → ..._exact_data_match/dlp_exact_data_match.go b/..._exact_data_match/dlp_exact_data_match.go → ..._exact_data_match/dlp_exact_data_match.go
diff --git a/zia/services/dlp_exact_data_match/service.go → ...vices/dlp/dlp_exact_data_match/service.go b/zia/services/dlp_exact_data_match/service.go → ...vices/dlp/dlp_exact_data_match/service.go
diff --git a/...vices/dlp_icap_servers/dlp_icap_server.go → ...s/dlp/dlp_icap_servers/dlp_icap_server.go b/...vices/dlp_icap_servers/dlp_icap_server.go → ...s/dlp/dlp_icap_servers/dlp_icap_server.go
diff --git a/.../dlp_icap_servers/dlp_icap_server_test.go → .../dlp_icap_servers/dlp_icap_server_test.go b/.../dlp_icap_servers/dlp_icap_server_test.go → .../dlp_icap_servers/dlp_icap_server_test.go
diff --git a/zia/services/dlp_icap_servers/service.go → zia/services/dlp/dlp_icap_servers/service.go b/zia/services/dlp_icap_servers/service.go → zia/services/dlp/dlp_icap_servers/service.go
diff --git a/...ices/dlp_idm_profiles/dlp_idm_profiles.go → .../dlp/dlp_idm_profiles/dlp_idm_profiles.go b/...ices/dlp_idm_profiles/dlp_idm_profiles.go → .../dlp/dlp_idm_profiles/dlp_idm_profiles.go
diff --git a/...dlp_idm_profiles/dlp_idm_profiles_lite.go → ...dlp_idm_profiles/dlp_idm_profiles_lite.go b/...dlp_idm_profiles/dlp_idm_profiles_lite.go → ...dlp_idm_profiles/dlp_idm_profiles_lite.go
diff --git a/zia/services/dlp_idm_profiles/service.go → zia/services/dlp/dlp_idm_profiles/service.go b/zia/services/dlp_idm_profiles/service.go → zia/services/dlp/dlp_idm_profiles/service.go
diff --git a/..._servers/dlp_incident_receiver_servers.go → ..._servers/dlp_incident_receiver_servers.go b/..._servers/dlp_incident_receiver_servers.go → ..._servers/dlp_incident_receiver_servers.go
diff --git a/...ers/dlp_incident_receiver_servers_test.go → ...ers/dlp_incident_receiver_servers_test.go b/...ers/dlp_incident_receiver_servers_test.go → ...ers/dlp_incident_receiver_servers_test.go
diff --git a/.../dlp_incident_receiver_servers/service.go → .../dlp_incident_receiver_servers/service.go b/.../dlp_incident_receiver_servers/service.go → .../dlp_incident_receiver_servers/service.go
diff --git a/..._templates/dlp_notification_template.html → ..._templates/dlp_notification_template.html b/..._templates/dlp_notification_template.html → ..._templates/dlp_notification_template.html
diff --git a/...n_templates/dlp_notification_template.txt → ...n_templates/dlp_notification_template.txt b/...n_templates/dlp_notification_template.txt → ...n_templates/dlp_notification_template.txt
diff --git a/...n_templates/dlp_notification_templates.go → ...n_templates/dlp_notification_templates.go b/...n_templates/dlp_notification_templates.go → ...n_templates/dlp_notification_templates.go
diff --git a/...plates/dlp_notification_templates_test.go → ...plates/dlp_notification_templates_test.go b/...plates/dlp_notification_templates_test.go → ...plates/dlp_notification_templates_test.go
@@ -243,3 +243,55 @@ func tryRetrieveResource(s *Service, id int) (*DlpNotificationTemplates, error)
 
 	return nil, err
 }
+
+func TestRetrieveNonExistentResource(t *testing.T) {
+	client, err := tests.NewZiaClient()
+	if err != nil {
+		t.Fatalf("Error creating client: %v", err)
+	}
+	service := New(client)
+
+	_, err = service.Get(0)
+	if err == nil {
+		t.Error("Expected error retrieving non-existent resource, but got nil")
+	}
+}
+
+func TestDeleteNonExistentResource(t *testing.T) {
+	client, err := tests.NewZiaClient()
+	if err != nil {
+		t.Fatalf("Error creating client: %v", err)
+	}
+	service := New(client)
+
+	_, err = service.Delete(0)
+	if err == nil {
+		t.Error("Expected error deleting non-existent resource, but got nil")
+	}
+}
+
+func TestUpdateNonExistentResource(t *testing.T) {
+	client, err := tests.NewZiaClient()
+	if err != nil {
+		t.Fatalf("Error creating client: %v", err)
+	}
+	service := New(client)
+
+	_, _, err = service.Update(0, &DlpNotificationTemplates{})
+	if err == nil {
+		t.Error("Expected error updating non-existent resource, but got nil")
+	}
+}
+
+func TestGetByNameNonExistentResource(t *testing.T) {
+	client, err := tests.NewZiaClient()
+	if err != nil {
+		t.Fatalf("Error creating client: %v", err)
+	}
+	service := New(client)
+
+	_, err = service.GetByName("non-existent-name")
+	if err == nil {
+		t.Error("Expected error retrieving resource by non-existent name, but got nil")
+	}
+}
diff --git a/...ces/dlp_notification_templates/service.go → ...dlp/dlp_notification_templates/service.go b/...ces/dlp_notification_templates/service.go → ...dlp/dlp_notification_templates/service.go
diff --git a/zia/services/dlp_web_rules/dlp_web_rules.go → ...rvices/dlp/dlp_web_rules/dlp_web_rules.go b/zia/services/dlp_web_rules/dlp_web_rules.go → ...rvices/dlp/dlp_web_rules/dlp_web_rules.go
diff --git a/...vices/dlp_web_rules/dlp_web_rules_test.go → ...s/dlp/dlp_web_rules/dlp_web_rules_test.go b/...vices/dlp_web_rules/dlp_web_rules_test.go → ...s/dlp/dlp_web_rules/dlp_web_rules_test.go
@@ -231,3 +231,55 @@ func tryRetrieveResource(s *Service, id int) (*WebDLPRules, error) {
 
 	return nil, err
 }
+
+func TestRetrieveNonExistentResource(t *testing.T) {
+	client, err := tests.NewZiaClient()
+	if err != nil {
+		t.Fatalf("Error creating client: %v", err)
+	}
+	service := New(client)
+
+	_, err = service.Get(0)
+	if err == nil {
+		t.Error("Expected error retrieving non-existent resource, but got nil")
+	}
+}
+
+func TestDeleteNonExistentResource(t *testing.T) {
+	client, err := tests.NewZiaClient()
+	if err != nil {
+		t.Fatalf("Error creating client: %v", err)
+	}
+	service := New(client)
+
+	_, err = service.Delete(0)
+	if err == nil {
+		t.Error("Expected error deleting non-existent resource, but got nil")
+	}
+}
+
+func TestUpdateNonExistentResource(t *testing.T) {
+	client, err := tests.NewZiaClient()
+	if err != nil {
+		t.Fatalf("Error creating client: %v", err)
+	}
+	service := New(client)
+
+	_, err = service.Update(0, &WebDLPRules{})
+	if err == nil {
+		t.Error("Expected error updating non-existent resource, but got nil")
+	}
+}
+
+func TestGetByNameNonExistentResource(t *testing.T) {
+	client, err := tests.NewZiaClient()
+	if err != nil {
+		t.Fatalf("Error creating client: %v", err)
+	}
+	service := New(client)
+
+	_, err = service.GetByName("non-existent-name")
+	if err == nil {
+		t.Error("Expected error retrieving resource by non-existent name, but got nil")
+	}
+}
diff --git a/zia/services/dlp_web_rules/service.go → zia/services/dlp/dlp_web_rules/service.go b/zia/services/dlp_web_rules/service.go → zia/services/dlp/dlp_web_rules/service.go
diff --git a/...rvices/dlpdictionaries/dlpdictionaries.go → ...es/dlp/dlpdictionaries/dlpdictionaries.go b/...rvices/dlpdictionaries/dlpdictionaries.go → ...es/dlp/dlpdictionaries/dlpdictionaries.go
diff --git a/...s/dlpdictionaries/dlpdictionaries_test.go → ...p/dlpdictionaries/dlpdictionaries_test.go b/...s/dlpdictionaries/dlpdictionaries_test.go → ...p/dlpdictionaries/dlpdictionaries_test.go
@@ -217,3 +217,55 @@ func tryRetrieveResource(s *Service, id int) (*DlpDictionary, error) {
 
 	return nil, err
 }
+
+func TestRetrieveNonExistentResource(t *testing.T) {
+	client, err := tests.NewZiaClient()
+	if err != nil {
+		t.Fatalf("Error creating client: %v", err)
+	}
+	service := New(client)
+
+	_, err = service.Get(0)
+	if err == nil {
+		t.Error("Expected error retrieving non-existent resource, but got nil")
+	}
+}
+
+func TestDeleteNonExistentResource(t *testing.T) {
+	client, err := tests.NewZiaClient()
+	if err != nil {
+		t.Fatalf("Error creating client: %v", err)
+	}
+	service := New(client)
+
+	_, err = service.DeleteDlpDictionary(0)
+	if err == nil {
+		t.Error("Expected error deleting non-existent resource, but got nil")
+	}
+}
+
+func TestUpdateNonExistentResource(t *testing.T) {
+	client, err := tests.NewZiaClient()
+	if err != nil {
+		t.Fatalf("Error creating client: %v", err)
+	}
+	service := New(client)
+
+	_, _, err = service.Update(0, &DlpDictionary{})
+	if err == nil {
+		t.Error("Expected error updating non-existent resource, but got nil")
+	}
+}
+
+func TestGetByNameNonExistentResource(t *testing.T) {
+	client, err := tests.NewZiaClient()
+	if err != nil {
+		t.Fatalf("Error creating client: %v", err)
+	}
+	service := New(client)
+
+	_, err = service.GetByName("non-existent-name")
+	if err == nil {
+		t.Error("Expected error retrieving resource by non-existent name, but got nil")
+	}
+}
diff --git a/zia/services/dlpdictionaries/service.go → zia/services/dlp/dlpdictionaries/service.go b/zia/services/dlpdictionaries/service.go → zia/services/dlp/dlpdictionaries/service.go
diff --git a/zia/services/firewallpolicies/filteringrules/firewall_filtering_rule_test.go b/zia/services/firewallpolicies/filteringrules/firewall_filtering_rule_test.go
@@ -227,3 +227,55 @@ func tryRetrieveResource(s *Service, id int) (*FirewallFilteringRules, error) {
 
 	return nil, err
 }
+
+func TestRetrieveNonExistentResource(t *testing.T) {
+	client, err := tests.NewZiaClient()
+	if err != nil {
+		t.Fatalf("Error creating client: %v", err)
+	}
+	service := New(client)
+
+	_, err = service.Get(0)
+	if err == nil {
+		t.Error("Expected error retrieving non-existent resource, but got nil")
+	}
+}
+
+func TestDeleteNonExistentResource(t *testing.T) {
+	client, err := tests.NewZiaClient()
+	if err != nil {
+		t.Fatalf("Error creating client: %v", err)
+	}
+	service := New(client)
+
+	_, err = service.Delete(0)
+	if err == nil {
+		t.Error("Expected error deleting non-existent resource, but got nil")
+	}
+}
+
+func TestUpdateNonExistentResource(t *testing.T) {
+	client, err := tests.NewZiaClient()
+	if err != nil {
+		t.Fatalf("Error creating client: %v", err)
+	}
+	service := New(client)
+
+	_, err = service.Update(0, &FirewallFilteringRules{})
+	if err == nil {
+		t.Error("Expected error updating non-existent resource, but got nil")
+	}
+}
+
+func TestGetByNameNonExistentResource(t *testing.T) {
+	client, err := tests.NewZiaClient()
+	if err != nil {
+		t.Fatalf("Error creating client: %v", err)
+	}
+	service := New(client)
+
+	_, err = service.GetByName("non-existent-name")
+	if err == nil {
+		t.Error("Expected error retrieving resource by non-existent name, but got nil")
+	}
+}
diff --git a/zia/services/firewallpolicies/ipdestinationgroups/ipdestinationgroups_test.go b/zia/services/firewallpolicies/ipdestinationgroups/ipdestinationgroups_test.go
@@ -247,3 +247,55 @@ func tryRetrieveResource(s *Service, id int) (*IPDestinationGroups, error) {
 
 	return nil, err
 }
+
+func TestRetrieveNonExistentResource(t *testing.T) {
+	client, err := tests.NewZiaClient()
+	if err != nil {
+		t.Fatalf("Error creating client: %v", err)
+	}
+	service := New(client)
+
+	_, err = service.Get(0)
+	if err == nil {
+		t.Error("Expected error retrieving non-existent resource, but got nil")
+	}
+}
+
+func TestDeleteNonExistentResource(t *testing.T) {
+	client, err := tests.NewZiaClient()
+	if err != nil {
+		t.Fatalf("Error creating client: %v", err)
+	}
+	service := New(client)
+
+	_, err = service.Delete(0)
+	if err == nil {
+		t.Error("Expected error deleting non-existent resource, but got nil")
+	}
+}
+
+func TestUpdateNonExistentResource(t *testing.T) {
+	client, err := tests.NewZiaClient()
+	if err != nil {
+		t.Fatalf("Error creating client: %v", err)
+	}
+	service := New(client)
+
+	_, _, err = service.Update(0, &IPDestinationGroups{})
+	if err == nil {
+		t.Error("Expected error updating non-existent resource, but got nil")
+	}
+}
+
+func TestGetByNameNonExistentResource(t *testing.T) {
+	client, err := tests.NewZiaClient()
+	if err != nil {
+		t.Fatalf("Error creating client: %v", err)
+	}
+	service := New(client)
+
+	_, err = service.GetByName("non-existent-name")
+	if err == nil {
+		t.Error("Expected error retrieving resource by non-existent name, but got nil")
+	}
+}