Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed application segment match_style validation #476

Merged
merged 2 commits into from
Aug 21, 2024

Conversation

willguibr
Copy link
Member

fix: Fixed application segment match_style validation

@willguibr willguibr self-assigned this Aug 15, 2024
@willguibr willguibr temporarily deployed to ZPA_BETA_TENANT01 August 15, 2024 19:56 — with GitHub Actions Inactive
@willguibr willguibr added type/bug Something isn't working documentation Improvements or additions to documentation labels Aug 15, 2024
@willguibr willguibr temporarily deployed to ZPA_PROD_TENANT01 August 15, 2024 20:12 — with GitHub Actions Inactive
@codecov-commenter
Copy link

codecov-commenter commented Aug 15, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 76.14%. Comparing base (a74ddce) to head (e1a0b56).

Files Patch % Lines
zpa/resource_zpa_application_segment.go 83.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #476      +/-   ##
==========================================
- Coverage   76.26%   76.14%   -0.12%     
==========================================
  Files          92       92              
  Lines       16818    16823       +5     
==========================================
- Hits        12826    12810      -16     
- Misses       3133     3151      +18     
- Partials      859      862       +3     
Files Coverage Δ
...resource_zpa_application_segment_browser_access.go 61.90% <ø> (-1.09%) ⬇️
zpa/resource_zpa_application_segment_inspection.go 65.25% <100.00%> (ø)
zpa/resource_zpa_application_segment_pra.go 58.46% <100.00%> (-5.54%) ⬇️
zpa/resource_zpa_application_segment.go 69.19% <83.33%> (+2.24%) ⬆️

... and 3 files with indirect coverage changes

@willguibr willguibr temporarily deployed to ZPA_BETA_TENANT01 August 21, 2024 04:33 — with GitHub Actions Inactive
@willguibr willguibr temporarily deployed to ZPA_PROD_TENANT01 August 21, 2024 04:49 — with GitHub Actions Inactive
@willguibr willguibr merged commit 9f24683 into master Aug 21, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation type/bug Something isn't working
Projects
Status: 🚀 Shipped
Development

Successfully merging this pull request may close these issues.

2 participants