Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added Application Segment By Type data Source and Fixes #455

Merged
merged 2 commits into from
May 18, 2024

Conversation

willguibr
Copy link
Member

feat: Added Application Segment By Type data Source and Fixes

@willguibr willguibr self-assigned this May 18, 2024
@willguibr willguibr added documentation Improvements or additions to documentation type/enhancement New feature or request new-acceptance-test new-acceptance-test labels May 18, 2024
@willguibr willguibr temporarily deployed to ZPA_QA2_TENANT01 May 18, 2024 05:39 — with GitHub Actions Inactive
@willguibr willguibr temporarily deployed to ZPA_QA_TENANT01 May 18, 2024 05:39 — with GitHub Actions Inactive
@willguibr willguibr temporarily deployed to ZPA_QA_TENANT02 May 18, 2024 05:39 — with GitHub Actions Inactive
@codecov-commenter
Copy link

codecov-commenter commented May 18, 2024

Codecov Report

Attention: Patch coverage is 89.10891% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 76.69%. Comparing base (eee8d95) to head (49680c0).
Report is 2 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #455      +/-   ##
==========================================
+ Coverage   76.39%   76.69%   +0.29%     
==========================================
  Files          89       90       +1     
  Lines       15752    15826      +74     
==========================================
+ Hits        12033    12137     +104     
+ Misses       3016     2980      -36     
- Partials      703      709       +6     
Files Coverage Δ
zpa/config.go 96.29% <100.00%> (+0.06%) ⬆️
zpa/provider.go 91.97% <100.00%> (+0.04%) ⬆️
zpa/resource_zpa_service_edge_group.go 76.02% <100.00%> (ø)
.../data_source_zpa_cloud_browser_isolation_region.go 48.38% <0.00%> (+8.91%) ⬆️
zpa/data_source_zpa_customer_version_profile.go 84.27% <50.00%> (+2.95%) ⬆️
zpa/data_source_zpa_isolation_profiles.go 94.20% <50.00%> (+7.36%) ⬆️
zpa/data_source_zpa_application_segment_by_type.go 91.39% <91.39%> (ø)

... and 9 files with indirect coverage changes

@willguibr willguibr temporarily deployed to ZPA_BETA_TENANT01 May 18, 2024 05:56 — with GitHub Actions Inactive
@willguibr willguibr temporarily deployed to ZPA_PROD_TENANT01 May 18, 2024 06:11 — with GitHub Actions Inactive
@willguibr willguibr merged commit 75a6e17 into master May 18, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation new-acceptance-test new-acceptance-test type/enhancement New feature or request
Projects
Status: 🚀 Shipped
Development

Successfully merging this pull request may close these issues.

2 participants