Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RBAC checking via custom authHandler function + SAF query interpretation #281
base: v1.x/staging
Are you sure you want to change the base?
RBAC checking via custom authHandler function + SAF query interpretation #281
Changes from 3 commits
3a8e00b
94742a0
278dc2b
35fe4be
f4fb448
9a191ad
2b271d7
40c0770
7df8380
21eb96d
038b915
0d154ad
c91b2dc
54a35c5
a618f31
a6ef66e
245cdbc
98cd911
a7a4e1e
b0f8914
2b55af4
63ce32f
a132c8b
0c1b0f5
4c50186
8da7246
f11219f
efde2a2
0add3ec
3eaf7a0
f35aa89
357f0d0
06a16ef
86ee872
21b1496
970cd23
8a7ad43
60f1e4c
4beeca2
c537201
371319a
a9f1ed1
7840318
954f921
11ff99f
9590ce1
ac967f2
5ade5c9
ef8b441
ef78692
894bc65
f0d839a
5f4f553
f9e437d
1a63674
961b7a7
f774e80
a4ad82a
f3b8d91
ddf0408
e2ed56e
47a8af9
4fc145c
542f458
414466c
ad39d3b
3b10697
918bf99
6b1f6b4
b83e85e
42acd8e
a4b56df
909ecb2
0899ef7
7c6cd42
acf074c
46e527d
ea23113
65e909e
6a66374
47b6665
8160346
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Buffer overflow is possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Buffer overflow is possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Buffer overflow is possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Buffer overflow is possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Buffer overflow is possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Buffer overflow is possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Buffer overflow is possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rootServiceName
may be uninitialized.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it ever
-1
?getProfileNameFromRequest
does the following:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wouldn't NULL pointer work here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible that someone malicious will send multiple malformed requests flooding the log?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
?