Add job name validation (#87)

* add jobName validation Signed-off-by: Anatoli Kalbasin <[email protected]> * delete testing mark Signed-off-by: Anatoli Kalbasin <[email protected]> --------- Signed-off-by: Anatoli Kalbasin <[email protected]>
zowe · Oct 22, 2024 · 9bc076b · 9bc076b
1 parent 663d4ca
commit 9bc076b
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 2 deletions.
diff --git a/src/main/kotlin/org/zowe/zdevops/classic/steps/SubmitJobStep.kt b/src/main/kotlin/org/zowe/zdevops/classic/steps/SubmitJobStep.kt
@@ -1,11 +1,15 @@
 /*
+ * Copyright (c) 2024 IBA Group.
+ *
  * This program and the accompanying materials are made available under the terms of the
  * Eclipse Public License v2.0 which accompanies this distribution, and is available at
  * https://www.eclipse.org/legal/epl-v20.html
  *
  * SPDX-License-Identifier: EPL-2.0
  *
- * Copyright IBA Group 2022
+ * Contributors:
+ *   IBA Group
+ *   Zowe Community
  */
 
 package org.zowe.zdevops.classic.steps
@@ -15,12 +19,15 @@ import hudson.Extension
 import hudson.Launcher
 import hudson.model.AbstractBuild
 import hudson.model.BuildListener
+import hudson.util.FormValidation
 import org.kohsuke.stapler.DataBoundConstructor
+import org.kohsuke.stapler.QueryParameter
 import org.kohsuke.stapler.bind.JavaScriptMethod
 import org.zowe.zdevops.Messages
 import org.zowe.zdevops.classic.AbstractBuildStep
 import org.zowe.zdevops.logic.submitJob
 import org.zowe.zdevops.logic.submitJobSync
+import org.zowe.zdevops.utils.validateFieldIsNotEmpty
 
 class SubmitJobStep
 @DataBoundConstructor
@@ -66,5 +73,16 @@ constructor(
     fun createStepId(): String {
       return marker + lastStepId++.toString()
     }
+
+    /**
+     * Performs form validation for the 'jobName' parameter to ensure it is not empty.
+     *
+     * @param jobName job to run
+     * @return A {@link FormValidation} object indicating whether the field is valid or contains an error.
+     */
+    fun doCheckJobName(@QueryParameter jobName: String): FormValidation? {
+      return validateFieldIsNotEmpty(jobName)
+    }
+
   }
 }
diff --git a/src/main/resources/org/zowe/zdevops/classic/steps/SubmitJobStep/config.jelly b/src/main/resources/org/zowe/zdevops/classic/steps/SubmitJobStep/config.jelly
@@ -5,7 +5,6 @@
 <jelly:jelly xmlns:jelly="jelly:core" xmlns:form="/lib/form" xmlns:stapler="jelly:stapler">
 
     <jelly:set var="stepId" value="${descriptor.createStepId()}" />
-    <p>${stepId}</p>
 
     <form:entry field="connectionName" title="${%zdevops.classic.connection.title}">
 		<form:select/>