WIP: Zit 161

[stevenhorsman]

No description provided.

[stevenhorsman]

Tested again staging here: https://wash.zowe.org:8443/job/zowe-install-test/view/change-requests/job/PR-162/2/

[jackjia-ibm]

Thanks Steve.

I do have few questions regarding the script, but it's not related to this change.

• zowe-check-prereqs.sh is only running when testing convenient build. If the end-user is installing SMPE, will the user be able to run this script?
• when checking node version in zowe-check-prereqs.sh, it runs node --version directly. This has wild assumptions like the node version we are checking is the one will be used to start Zowe, and the user has NODE_HOME defined.
• I think [[ "$nodeVersion" < "v6.14.4" ]] check will fail if the node version is above 10, is that right?

But anyway, those questions are not related to this PR. I just raise some questions and I feel I'm not fully trust this prereq check script. If we enable this [error]/[warning] check, it may give us some false alarms.

[stevenhorsman]

Hi Jack, thanks for the comments. My thoughts are:

• I think zowe-check-prereqs.sh is potentially valid for SMP/E, but I think that the FMID might have a dependency on Node anyway, so might be checked by that - probably no harm testing it in the build anyway (I've added it to Enhance test of check-pre-reqs #161) I think I've changed my mind here - check-pre-reqs as run in zowe-install-test is there to run before you've installed the product to see if you have the dependencies. In SMP/E there is no way to run it before the product is installed as the SMP/E lays the runtime directory straight out. There is a case for saying we could run the script in runtime, but we'd probably have to modify it as the environment is slightly different.
• I think we could/should add more support if NODE_HOME is not set - probably manually prompting the user to enter it (Check pre-reqs might not handle missing NODE_HOME well zowe-install-packaging#1080). For whether it is the version that zowe will use - remember that check-pre-reqs is just a script to test before you install if you have the requirements - the actual node version used when zowe starts is validated then (with the same logic hence the assumption of NODE_HOME)
• I'm not sure about node 10+ working - we don't have a node >8 to test with in Hursley - however I ran with node 12 on Marist and it didn't manage to get that far and had Error 0: /ZOWE/node/node-v12.14.1-os390-s390x/bin/node is not functioning correctly, so we need to investigate and fix that first. Node 12: validate-node.sh doesn't work with Node 12 zowe-install-packaging#1082
  Unfortunately given that we've just lost yet another week of dev time I'm not sure that we'll be able to look deeply into these right now, so I propose not merging this change in just yet.
  Any thoughts?

[jackjia-ibm]

Sounds good to me. Thanks Steve.