-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
draft holddata workflow #4138
base: v3.x/staging
Are you sure you want to change the base?
draft holddata workflow #4138
Conversation
Signed-off-by: MarkAckert <[email protected]>
build 6753 SUCCEEDED. |
Signed-off-by: MarkAckert <[email protected]>
build 6754 SUCCEEDED. |
Test workflow 5950 is started. |
Test workflow 5951 is started. |
build 6761 SUCCEEDED. |
Test workflow 5956 is started. |
Signed-off-by: MarkAckert <[email protected]>
Signed-off-by: MarkAckert <[email protected]>
build 6767 SUCCEEDED. |
Test workflow 5959 is started. |
Signed-off-by: MarkAckert <[email protected]>
build 6774 SUCCEEDED. |
Test workflow 5960 is started. |
Signed-off-by: MarkAckert <[email protected]>
build 6776 SUCCEEDED. |
Test workflow 5962 is started. |
This PR is an attempt to detect changes which may require HOLDDATA and flag them via a failing build if there is no matching HOLDDATA updates in the repository's SMP/e service directory.
There's no way we can detect every change which requires HOLDDATA, so ultimately the developers working on features must be responsible for updating HOLDDATA docs. To that end, a small blurb was added to the repo's README which points users to the SMP/e service directory for further instruction.
Tests in another PR showed the workflow works as intended, capturing changes to the SZWE* files and failing when HOLDDATA is absent.
Addresses #3854
Addresses #1576