Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

z/OSMF static definition file processing #4113

Open
wants to merge 1 commit into
base: v3.x/staging
Choose a base branch
from
Open

z/OSMF static definition file processing #4113

wants to merge 1 commit into from

Conversation

pablocarle
Copy link
Contributor

@pablocarle pablocarle commented Dec 23, 2024 •
edited
Loading

  • Tests for the changes have been added (for bug fixes / features)
  • Necessary documentation (if appropriate) have been added / updated
  • DCO signoffs have been added to all commits, including this PR

PR type

  • Feature

Changes proposed in this PR

Include logic to determine if connections from API ML components to z/OSMF are made using https (default) or HTTP (when outbound AT-TLS rules are in place)

Does this PR introduce a breaking change?

  • Yes
  • No

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 23, 2024 •
edited
Loading

build 6636 SUCCEEDED.
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/12467254071

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 23, 2024 •
edited
Loading

Test workflow 5847 is started.
Running install test: Convenience Pax
The zowe artifact being used by this test workflow: libs-snapshot-local/org/zowe/3.1.0-PR-4113/zowe-3.1.0-pr-4113-6636-20241223130750.pax
Running on machine: zzow11
Result: SUCCESS
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/12467325892

1000TurquoisePogs
1000TurquoisePogs reviewed Jan 2, 2025
View reviewed changes
bin/libs/component.ts
@@ -418,6 +418,22 @@ export function processComponentApimlStaticDefinitions(componentDir: string): bo

const contents = xplatform.loadFileUTF8(path,xplatform.AUTO_DETECT);
if (contents) {
const zosmfScheme = std.getenv("ZOSMF_SCHEME");
const attls = std.getenv("ZWE_zowe_network_client_tls_attls");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will not work for configs where people have recommended enabling attls through only the server variable.

It would be better to say if the client variable isn't defined, to use the server variable's value.
Something like we do here:

https://github.com/zowe/zlux-server-framework/blob/v3.x/staging/lib/util.js#L510-L520

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1000TurquoisePogs 1000TurquoisePogs 1000TurquoisePogs left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pablocarle @1000TurquoisePogs @zowe-robot