Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit node minimum to v18 and use v18 during build #4092

Merged
merged 8 commits into from
Dec 9, 2024
Merged

Limit node minimum to v18 and use v18 during build #4092

merged 8 commits into from
Dec 9, 2024

Conversation

1000TurquoisePogs
Copy link
Member

This pr modifies the version check on node to not allow v16 which is now out of support.
This also changes the pre-package build step to use v18

@1000TurquoisePogs
Update node min version
e79183b 
Signed-off-by: 1000TurquoisePogs <[email protected]>
@1000TurquoisePogs
Update node.sh
51cf59b 
Signed-off-by: 1000TurquoisePogs <[email protected]>
@1000TurquoisePogs
Use node 18 during build
9ed0194 
Signed-off-by: 1000TurquoisePogs <[email protected]>
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 21, 2024 •
edited
Loading

build 6470 SUCCEEDED.
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/11950293150

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 21, 2024 •
edited
Loading

Test workflow 5705 is started.
Running install test: Convenience Pax
The zowe artifact being used by this test workflow: libs-snapshot-local/org/zowe/3.1.0-PR-4092/zowe-3.1.0-pr-4092-6470-20241121093001.pax
Running on machine: zzow09
Result: FAILURE
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/11950377418

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 26, 2024 •
edited
Loading

build 6496 SUCCEEDED.
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/12038550465

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 26, 2024 •
edited
Loading

Test workflow 5721 is started.
Running install test: Convenience Pax
The zowe artifact being used by this test workflow: libs-snapshot-local/org/zowe/3.1.0-PR-4092/zowe-3.1.0-pr-4092-6496-20241126203557.pax
Running on machine: zzow09
Result: FAILURE
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/12038621870

@MarkAckert MarkAckert self-requested a review November 26, 2024 20:48
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 2, 2024 •
edited
Loading

build 6529 SUCCEEDED.
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/12127470018

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 2, 2024 •
edited
Loading

Test workflow 5750 is started.
Running install test: Convenience Pax
The zowe artifact being used by this test workflow: libs-snapshot-local/org/zowe/3.1.0-PR-4092/zowe-3.1.0-pr-4092-6529-20241202203608.pax
Running on machine: zzow09
Result: FAILURE
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/12127542472

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2024 •
edited
Loading

build 6541 SUCCEEDED.
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/12166826786

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2024 •
edited
Loading

Test workflow 5759 is started.
Running install test: Convenience Pax
The zowe artifact being used by this test workflow: libs-snapshot-local/org/zowe/3.1.0-PR-4092/zowe-3.1.0-pr-4092-6541-20241204193339.pax
Running on machine: zzow11
Result: FAILURE
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/12166978792

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 6, 2024 •
edited
Loading

build 6552 SUCCEEDED.
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/12204113258

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 6, 2024 •
edited
Loading

Test workflow 5770 is started.
Running install test: Convenience Pax
The zowe artifact being used by this test workflow: libs-snapshot-local/org/zowe/3.1.0-PR-4092/zowe-3.1.0-pr-4092-6552-20241206183514.pax
Running on machine: zzow11
Result: FAILURE
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/12204224503

@1000TurquoisePogs 1000TurquoisePogs marked this pull request as ready for review December 9, 2024 14:39
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 9, 2024 •
edited
Loading

build 6552 SUCCEEDED.
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/12204113258

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 9, 2024 •
edited
Loading

Test workflow 5777 is started.
Running install test: Convenience Pax
The zowe artifact being used by this test workflow: libs-snapshot-local/org/zowe/3.1.0-PR-4092/zowe-3.1.0-pr-4092-6552-20241209144744.pax
Running on machine: zzow09
Result: FAILURE
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/12238078952

@MarkAckert
change node_home_pattern
b98256b 
Signed-off-by: MarkAckert <[email protected]>
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 9, 2024 •
edited
Loading

build 6562 SUCCEEDED.
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/12239351179

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 9, 2024 •
edited
Loading

Test workflow 5778 is started.
Running install test: Convenience Pax
The zowe artifact being used by this test workflow: libs-snapshot-local/org/zowe/3.1.0-PR-4092/zowe-3.1.0-pr-4092-6562-20241209160310.pax
Running on machine: zzow09
Result: SUCCESS
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/12239486557

@MarkAckert MarkAckert merged commit 1f0f969 into v3.x/staging Dec 9, 2024
12 checks passed
@MarkAckert MarkAckert deleted the chore/v3/node-18 branch December 9, 2024 16:53
MarkAckert added a commit that referenced this pull request Dec 9, 2024
@MarkAckert
Merge cherry-pick PR #4092 into v2
d2873eb 
Signed-off-by: MarkAckert <[email protected]>
@MarkAckert MarkAckert mentioned this pull request Dec 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkAckert MarkAckert MarkAckert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@1000TurquoisePogs @MarkAckert @zowe-robot