Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read yaml by configmgr - zwe init #4088

Merged
merged 4 commits into from
Nov 20, 2024
Merged

Conversation

Martin-Zeithaml
Copy link
Contributor

Continuation of #4069.

Simple NodeJS dependency removal for zwe init command while waiting for #3718.

Signed-off-by: Martin Zeithaml <[email protected]>
Copy link

github-actions bot commented Nov 14, 2024

build 6434 SUCCEEDED.
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/11836661856

Copy link

github-actions bot commented Nov 14, 2024

build 6435 SUCCEEDED.
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/11836669777

Copy link

github-actions bot commented Nov 14, 2024

Test workflow 5685 is started.
Running install test: Convenience Pax
The zowe artifact being used by this test workflow: libs-snapshot-local/org/zowe/3.1.0-PR-4088/zowe-3.1.0-pr-4088-6435-20241114115943.pax
Running on machine: zzow10
Result: FAILURE
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/11836737128

Copy link

github-actions bot commented Nov 14, 2024

Test workflow 5686 is started.
Running install test: Convenience Pax
The zowe artifact being used by this test workflow: libs-snapshot-local/org/zowe/3.1.0-PR-4088/zowe-3.1.0-pr-4088-6434-20241114115956.pax
Running on machine: zzow10
Result: FAILURE
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/11836741168

Copy link
Member

@1000TurquoisePogs 1000TurquoisePogs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this fails due to different behavior of configmgr:

- read_yaml_configmgr process /zowe/inst/no-nodeinit/zowe.yaml and extract '.zowe.setup.certificate.keyring.zOSMF.user -> /zowe/setup/certificate/keyring/zOSMF/user'
  * Exit code: 0
  * Output:
    error not found, reason=101
...
  * certificate pkcs12 import --keystore /zowe/inst/no-nodeinit/keystore/error not found, reason=101/error not found, reason=101.keystore.p12 --password error not found, reason=101 --alias error not found, reason=101 --source-keystore error not found, reason=101 --source-password error not found, reason=101 --source-alias error not found, reason=101

looks like errors need to be >/dev/null

@Martin-Zeithaml
Copy link
Contributor Author

this fails due to different behavior of configmgr:

- read_yaml_configmgr process /zowe/inst/no-nodeinit/zowe.yaml and extract '.zowe.setup.certificate.keyring.zOSMF.user -> /zowe/setup/certificate/keyring/zOSMF/user'
  * Exit code: 0
  * Output:
    error not found, reason=101
...
  * certificate pkcs12 import --keystore /zowe/inst/no-nodeinit/keystore/error not found, reason=101/error not found, reason=101.keystore.p12 --password error not found, reason=101 --alias error not found, reason=101 --source-keystore error not found, reason=101 --source-password error not found, reason=101 --source-alias error not found, reason=101

looks like errors need to be >/dev/null

It seems to be more complicated, the error in printed to stdout and return code is always 0 (found/not found). I am afraid, the only shell solution for now is to check if the return value is error not found, reason= and hoping it is not real value.

The right solution would be update configmgr to return > 0 for "not found" case.

Signed-off-by: Martin Zeithaml <[email protected]>
Copy link

github-actions bot commented Nov 15, 2024

build 6441 SUCCEEDED.
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/11857122015

Copy link

github-actions bot commented Nov 15, 2024

Test workflow 5691 is started.
Running install test: Convenience Pax
The zowe artifact being used by this test workflow: libs-snapshot-local/org/zowe/3.1.0-PR-4088/zowe-3.1.0-pr-4088-6441-20241115133136.pax
Running on machine: zzow09
Result: FAILURE
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/11857196617

Copy link

github-actions bot commented Nov 19, 2024

build 6453 SUCCEEDED.
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/11910233222

Copy link

github-actions bot commented Nov 19, 2024

Test workflow 5699 is started.
Running install test: Convenience Pax
The zowe artifact being used by this test workflow: libs-snapshot-local/org/zowe/3.1.0-PR-4088/zowe-3.1.0-pr-4088-6453-20241119094229.pax
Running on machine: zzow10
Result: FAILURE
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/11910321184

@MarkAckert MarkAckert merged commit 87f02f7 into v3.x/staging Nov 20, 2024
10 of 12 checks passed
@MarkAckert MarkAckert deleted the v3.x/readYamlInit branch November 20, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants