Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V2: Check log directory #4063

Merged
merged 2 commits into from
Nov 4, 2024
Merged

V2: Check log directory #4063

merged 2 commits into from
Nov 4, 2024

Conversation

Martin-Zeithaml
Copy link
Contributor

@Martin-Zeithaml Martin-Zeithaml commented Oct 31, 2024

Please check if your PR fulfills the following requirements. This is simply a reminder of what we are going to look for before merging your PR. If you don't know all of this information when you create this PR, don't worry. You can edit this template as you're working on it.

  • DCO signoffs have been added to all commits, including this PR

PR type

What type of changes does your PR introduce to Zowe? Put an x in the box that applies to this PR. If you're unsure about any of them, don't hesitate to ask.

  • Bugfix

Relevant issues

Partially fixes #4062

Changes proposed in this PR

  • When --log-dir used for zwe command is a file, the command might end in the series of errors.

Does this PR introduce a breaking change?

  • No

Test

/zowe: head ./manifest.json | grep version
  "version": "2.18.1",
/zowe: cd bin/
/zowe/bin: ./zwe start -c ./zwe -l ./zwe
Error ZWEL0102E: Invalid parameter --log-dir=./zwe (not a directory)

Signed-off-by: Martin Zeithaml <[email protected]>
@Martin-Zeithaml Martin-Zeithaml changed the title Check log directory V2: Check log directory Oct 31, 2024
Copy link

github-actions bot commented Oct 31, 2024

build 6362 SUCCEEDED.
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/11609633857

Copy link

github-actions bot commented Oct 31, 2024

Test workflow 5642 is started.
Running install test: Convenience Pax
The zowe artifact being used by this test workflow: libs-snapshot-local/org/zowe/2.18.1-PR-4063/zowe-2.18.1-pr-4063-6362-20241031095347.pax
Running on machine: zzow06
Result: FAILURE
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/11609734186

@MarkAckert MarkAckert self-requested a review October 31, 2024 15:04
@MarkAckert MarkAckert added the Build: None Used in CI label Nov 4, 2024
@MarkAckert MarkAckert merged commit f9336bf into v2.x/staging Nov 4, 2024
7 checks passed
@MarkAckert MarkAckert deleted the v2.x/zweLogging branch November 4, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants