Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User/muzikovam/zowe yaml diff #3998

Merged
merged 59 commits into from
Sep 20, 2024
Merged

Conversation

muzikovam
Copy link
Contributor

Please check if your PR fulfills the following requirements. This is simply a reminder of what we are going to look for before merging your PR. If you don't know all of this information when you create this PR, don't worry. You can edit this template as you're working on it.

  • Tests for the changes have been added (for bug fixes / features)
  • Necessary documentation (if appropriate) have been added / updated
  • DCO signoffs have been added to all commits, including this PR

PR type

What type of changes does your PR introduce to Zowe? Put an x in the box that applies to this PR. If you're unsure about any of them, don't hesitate to ask.

  • Bugfix
  • Feature
  • Other... Please describe: just tests for yaml generated by ZWECONF workflow

Relevant issues

Fixes

Changes proposed in this PR

  • Just tests for yaml generated by ZWECONF workflow so that zowe.yaml produced by ZWECONF workflow has the same variables as zowe-example.yaml.

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR do something the person installing Zowe should know about?


  • Affected function: workflow *

  • Description: Test for ZWECONF workflow. *

  • Part: __ *

Just tests for yaml generated by ZWECONF workflow so that zowe.yaml produced by ZWECONF workflow has the same variables as zowe-example.yaml.

Is there a related doc issue or Pull Request?

Doc issue/PR number:

Other information

doing sed of properties file via JCL

Signed-off-by: mm667937 <[email protected]>
Signed-off-by: mm667937 <[email protected]>
Signed-off-by: mm667937 <[email protected]>
Signed-off-by: mm667937 <[email protected]>
Signed-off-by: mm667937 <[email protected]>
Signed-off-by: mm667937 <[email protected]>
download final zowe.yaml

Signed-off-by: mm667937 <[email protected]>
Signed-off-by: mm667937 <[email protected]>
…there because of permissions that the end user will have to solve, we don't need to)

Signed-off-by: mm667937 <[email protected]>
Signed-off-by: mm667937 <[email protected]>
Signed-off-by: mm667937 <[email protected]>
Signed-off-by: mm667937 <[email protected]>
Signed-off-by: mm667937 <[email protected]>
temporarily save files

Signed-off-by: Marketka <[email protected]>
Signed-off-by: mm667937 <[email protected]>
Signed-off-by: mm667937 <[email protected]>
Signed-off-by: mm667937 <[email protected]>
…kflow output and then comparing that diff to diff that is output on "live" example and wf output

Signed-off-by: mm667937 <[email protected]>
Copy link

github-actions bot commented Sep 19, 2024

Test workflow 5424 is started.
Running install test: Convenience Pax
The zowe artifact being used by this test workflow: libs-snapshot-local/org/zowe/3.0.0-PR-3998/zowe-3.0.0-pr-3998-6089-20240919121805.pax
Running on machine: zzow07
Result: SUCCESS
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/10940807586

Copy link

github-actions bot commented Sep 19, 2024

, SMPE, PSWI build 6090 SUCCEEDED.
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/10940892866

Copy link

github-actions bot commented Sep 19, 2024

Test workflow 5425 is started.
Running install test: Convenience Pax
The zowe artifact being used by this test workflow: libs-snapshot-local/org/zowe/3.0.0-PR-3998/zowe-3.0.0-pr-3998-6090-20240919131026.pax
Running on machine: zzow06
Result: SUCCESS
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/10941703488

@muzikovam
Copy link
Contributor Author

We agreed to separate the ZWECONF yaml test so it can run everytime. I will also try to delete private info from said test. So I am closing this PR for now.

@muzikovam muzikovam closed this Sep 19, 2024
@muzikovam muzikovam reopened this Sep 20, 2024
Copy link

github-actions bot commented Sep 20, 2024

build 6116 SUCCEEDED.
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/10959486314

Copy link

github-actions bot commented Sep 20, 2024

build 6117 SUCCEEDED.
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/10959583945

Copy link

github-actions bot commented Sep 20, 2024

Test workflow 5440 is started.
Running install test: Convenience Pax
The zowe artifact being used by this test workflow: libs-snapshot-local/org/zowe/3.0.0-PR-3998/zowe-3.0.0-pr-3998-6116-20240920125559.pax
Running on machine: zzow07
Result: SUCCESS
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/10959661495

Copy link

github-actions bot commented Sep 20, 2024

Test workflow 5441 is started.
Running install test: Convenience Pax
The zowe artifact being used by this test workflow: libs-snapshot-local/org/zowe/3.0.0-PR-3998/zowe-3.0.0-pr-3998-6117-20240920125714.pax
Running on machine: zzow08
Result: SUCCESS
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/10959681168

Copy link

github-actions bot commented Sep 20, 2024

build 6119 SUCCEEDED.
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/10962243944

Copy link

github-actions bot commented Sep 20, 2024

Test workflow 5443 is started.
Running install test: Convenience Pax
The zowe artifact being used by this test workflow: libs-snapshot-local/org/zowe/3.0.0-PR-3998/zowe-3.0.0-pr-3998-6119-20240920154638.pax
Running on machine: zzow06
Result: SUCCESS
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/10962324474

@MarkAckert
Copy link
Member

@muzikovam I split the PSWI YAML check into a new workflow, and will test it after it's merged into staging. Please let me know if this PR needs to make the 3.0.0 release.

@MarkAckert MarkAckert merged commit c88c59a into v3.x/staging Sep 20, 2024
10 of 12 checks passed
@MarkAckert MarkAckert deleted the user/muzikovam/zoweYamlDiff branch September 20, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build: PSWI Used in CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants