Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates on new v3 FMID #3650

Merged
merged 4 commits into from
Nov 30, 2023
Merged

Updates on new v3 FMID #3650

merged 4 commits into from
Nov 30, 2023

Conversation

ojcelis
Copy link
Contributor

@ojcelis ojcelis commented Nov 9, 2023

Please check if your PR fulfills the following requirements. This is simply a reminder of what we are going to look for before merging your PR. If you don't know all of this information when you create this PR, don't worry. You can edit this template as you're working on it.

  • Tests for the changes have been added (for bug fixes / features)
  • Necessary documentation (if appropriate) have been added / updated
  • DCO signoffs have been added to all commits, including this PR

PR type

What type of changes does your PR introduce to Zowe? Put an x in the box that applies to this PR. If you're unsure about any of them, don't hesitate to ask.

  • Bugfix
  • Feature
  • Other... Please describe:

Relevant issues

Fixes

Changes proposed in this PR

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR do something the person installing Zowe should know about?


  • Affected function: general area of interest *

  • Description: 1 line description *

  • Part: name of customizable file involved *

multi-line description

Is there a related doc issue or Pull Request?

Doc issue/PR number:

Other information

@ojcelis ojcelis requested a review from OnnoVdT November 9, 2023 15:37
Copy link

github-actions bot commented Nov 9, 2023

PAX build 4005 FAILED.
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/6814029833

Copy link

github-actions bot commented Nov 9, 2023

PAX build 4005 SUCCEEDED.
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/6814029833

@@ -1,5 +1,4 @@
<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML 3//EN">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updating the PD here is not useful, should be more explicit about that in the readme. The PD source is a BookManager script file based on on a template that is updated once in a while. To pass Shopz validation, you have to use the latest template. I have the PD script source on my system and adjust it each time I'm notified about a template update (together with updating the other 20 or so PDs I maintain). That script is converted to PDF and HTML, twice, once with IBM-specific data and once generic. It is that generic HTML file that is kept in Git so that the doc folks can pick it up.
For now your update will do, but we must replace closer to GA with the final one generated from script source.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good. I'll take note of this

@@ -34,7 +34,6 @@ Note: SUP should only be updated if most products depending on the
SUP(AZWE001)
DELETE(AZWE001)
3. remove select files from smpe/bld/service
- apar-bucket.txt
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the apar-bucket.txt file must also be removed when it is present. So this line should stay in the README.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will update it

Copy link

github-actions bot commented Nov 9, 2023

Test workflow 3501 is started.
Running install test: Convenience Pax
The zowe artifact being used by this test workflow: libs-snapshot-local/org/zowe/2.13.0-PR-3650/zowe-2.13.0-pr-3650-4005-20231109155928.pax
Running on machine: zzow03
Result: SUCCESS
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/6814285986

Copy link

github-actions bot commented Nov 9, 2023

PAX build 4006 SUCCEEDED.
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/6814319749

Copy link

github-actions bot commented Nov 9, 2023

Test workflow 3502 is started.
Running install test: Convenience Pax
The zowe artifact being used by this test workflow: libs-snapshot-local/org/zowe/2.13.0-PR-3650/zowe-2.13.0-pr-3650-4006-20231109160857.pax
Running on machine: zzow04
Result: SUCCESS
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/6814415588

Copy link

github-actions bot commented Nov 28, 2023

PAX build 4113 SUCCEEDED.
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/7022046343

Copy link

github-actions bot commented Nov 28, 2023

Test workflow 3601 is started.
Running install test: Convenience Pax
The zowe artifact being used by this test workflow: libs-snapshot-local/org/zowe/3.0.0-PR-3650/zowe-3.0.0-pr-3650-4113-20231128171510.pax
Running on machine: zzow04
Result: FAILURE
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/7022168939

Copy link

github-actions bot commented Nov 28, 2023

PAX build 4114 SUCCEEDED.
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/7022483378

Copy link

github-actions bot commented Nov 28, 2023

Test workflow 3603 is started.
Running install test: Convenience Pax
The zowe artifact being used by this test workflow: libs-snapshot-local/org/zowe/3.0.0-PR-3650/zowe-3.0.0-pr-3650-4114-20231128175232.pax
Running on machine: zzow08
Result: SUCCESS
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/7022577833

@MarkAckert MarkAckert merged commit ae57bda into v3.x/staging Nov 30, 2023
9 checks passed
@MarkAckert MarkAckert deleted the users/oscar/newFMIDforv3 branch November 30, 2023 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants