Skip to content

Commit

Permalink
don't quit early
Browse files Browse the repository at this point in the history
Signed-off-by: MarkAckert <[email protected]>
  • Loading branch information
MarkAckert committed Apr 17, 2024
1 parent a93a2ef commit 9ee1c3b
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions .github/scripts/manifest_verification/check_sources.js
Original file line number Diff line number Diff line change
Expand Up @@ -108,20 +108,21 @@ async function main() {
}
}

let didFail = false;

const failRepos = analyzedRepos.filter((item) => item.result === results.fail);
if (failRepos != null && failRepos.length > 0) {
core.warning('The following repositories do not have a matching tag or branch: ' + JSON.stringify(failRepos, null, {indent: 4}))
core.setFailed('There are manifest sourceDependencies without a matching tag or branch. Review the output and update the manifest.')
return;
}

const warnRepos = analyzedRepos.filter((item) => item.name === results.warn) ;
if (warnRepos != null && warnRepos.length > 0) {
core.warning('The following repositories have a branch instead of tag: ' + JSON.stringify(warnRepos, null, {indent: 4}))
if (isRcOrMaster(baseRef)) {
core.setFailed('Merges to RC and master require tags instead of branches for sourceDependencies.');
return;
}
}

}
main()

0 comments on commit 9ee1c3b

Please sign in to comment.