-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ds): Pass correct DS name in stat
when doing remote lookup
#3407
Conversation
Signed-off-by: Trae Yelovich <[email protected]>
Signed-off-by: Trae Yelovich <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3407 +/- ##
========================================
Coverage 93.18% 93.18%
========================================
Files 120 120
Lines 12502 12503 +1
Branches 2885 2761 -124
========================================
+ Hits 11650 11651 +1
Misses 851 851
Partials 1 1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Trae Yelovich <[email protected]>
📅 Suggested merge-by date: 2/5/2025 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @traeok!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies for the late review ❤️
LGTM! 😋
* fix: use path.basename and helper fn to extract DS name Signed-off-by: Trae Yelovich <[email protected]> * test: add unit test to verify proper DS name Signed-off-by: Trae Yelovich <[email protected]> * chore: update changelog Signed-off-by: Trae Yelovich <[email protected]> --------- Signed-off-by: Trae Yelovich <[email protected]> Co-authored-by: Timothy Johnson <[email protected]> Signed-off-by: Timothy Johnson <[email protected]>
* update lerna and remove un-needed changelog headers Signed-off-by: Billie Simmons <[email protected]> * add notes to readme's of VSC for older releases location with link Signed-off-by: Billie Simmons <[email protected]> * run package command Signed-off-by: Billie Simmons <[email protected]> * chore: downgrade ubuntu runners to ubuntu-22.04 Signed-off-by: Trae Yelovich <[email protected]> * fix: call Mutex.waitForUnlock instead of locking profile before request (#3409) * fix: call Mutex.waitForUnlock instead of locking profile before request Signed-off-by: Trae Yelovich <[email protected]> * fix: AuthHandler.waitForUnlock Signed-off-by: Trae Yelovich <[email protected]> * tests: AuthHandler.waitForUnlock Signed-off-by: Trae Yelovich <[email protected]> * fix: add true opt-in support for profile locks w/ extender types Signed-off-by: Trae Yelovich <[email protected]> --------- Signed-off-by: Trae Yelovich <[email protected]> * fix(ds): Pass correct DS name in `stat` when doing remote lookup (#3407) * fix: use path.basename and helper fn to extract DS name Signed-off-by: Trae Yelovich <[email protected]> * test: add unit test to verify proper DS name Signed-off-by: Trae Yelovich <[email protected]> * chore: update changelog Signed-off-by: Trae Yelovich <[email protected]> --------- Signed-off-by: Trae Yelovich <[email protected]> Co-authored-by: Timothy Johnson <[email protected]> Signed-off-by: Timothy Johnson <[email protected]> --------- Signed-off-by: Billie Simmons <[email protected]> Signed-off-by: Trae Yelovich <[email protected]> Signed-off-by: Timothy Johnson <[email protected]> Signed-off-by: Fernando Rijo Cedeno <[email protected]> Co-authored-by: Trae Yelovich <[email protected]> Co-authored-by: Timothy Johnson <[email protected]> Co-authored-by: Fernando Rijo Cedeno <[email protected]>
Proposed changes
Release Notes
Milestone:
Changelog:
Types of changes
Checklist
General
yarn workspace vscode-extension-for-zowe vscode:prepublish
pnpm --filter vscode-extension-for-zowe vscode:prepublish
Code coverage
Deployment