Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ds): Pass correct DS name in stat when doing remote lookup #3407

Merged
merged 4 commits into from
Jan 25, 2025

Conversation

traeok
Copy link
Member

@traeok traeok commented Jan 22, 2025

Proposed changes

Release Notes

Milestone:

Changelog:

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds or improves functionality)
  • Breaking change (a change that would cause existing functionality to not work as expected)
  • Documentation (Markdown, README updates)
  • Other (please specify above in "Proposed changes" section)

Checklist

General

  • I have read the CONTRIBUTOR GUIDANCE wiki
  • All PR dependencies have been merged and published (if applicable)
  • A GIF or screenshot is included in the PR for visual changes
  • The pre-publish command has been executed:
    • v2 and below: yarn workspace vscode-extension-for-zowe vscode:prepublish
    • v3: pnpm --filter vscode-extension-for-zowe vscode:prepublish

Code coverage

  • There is coverage for the code that I have added
  • I have added new test cases and they are passing
  • I have manually tested the changes

Deployment

  • I have added developer documentation (if applicable)
  • Documentation should be added to Zowe Docs
    • If you're an outside contributor, please post in the #zowe-doc Slack channel to coordinate documentation.
    • Otherwise, please check with the rest of the squad about any needed documentation before merging.
  • These changes may need ported to the appropriate branches (list here):

Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.18%. Comparing base (4fefdf9) to head (e495aba).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #3407    +/-   ##
========================================
  Coverage   93.18%   93.18%            
========================================
  Files         120      120            
  Lines       12502    12503     +1     
  Branches     2885     2761   -124     
========================================
+ Hits        11650    11651     +1     
  Misses        851      851            
  Partials        1        1            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Trae Yelovich <[email protected]>
@traeok traeok marked this pull request as ready for review January 22, 2025 16:40
Copy link

📅 Suggested merge-by date: 2/5/2025

Copy link
Member

@t1m0thyj t1m0thyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @traeok!

Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the late review ❤️
LGTM! 😋

@t1m0thyj t1m0thyj merged commit 94ffb67 into main Jan 25, 2025
33 checks passed
@t1m0thyj t1m0thyj deleted the fix/ds/remove-ext-during-list branch January 25, 2025 11:41
t1m0thyj added a commit that referenced this pull request Jan 25, 2025
* fix: use path.basename and helper fn to extract DS name

Signed-off-by: Trae Yelovich <[email protected]>

* test: add unit test to verify proper DS name

Signed-off-by: Trae Yelovich <[email protected]>

* chore: update changelog

Signed-off-by: Trae Yelovich <[email protected]>

---------

Signed-off-by: Trae Yelovich <[email protected]>
Co-authored-by: Timothy Johnson <[email protected]>
Signed-off-by: Timothy Johnson <[email protected]>
traeok added a commit that referenced this pull request Jan 28, 2025
* update lerna and remove un-needed changelog headers

Signed-off-by: Billie Simmons <[email protected]>

* add notes to readme's of VSC for older releases location with link

Signed-off-by: Billie Simmons <[email protected]>

* run package command

Signed-off-by: Billie Simmons <[email protected]>

* chore: downgrade ubuntu runners to ubuntu-22.04

Signed-off-by: Trae Yelovich <[email protected]>

* fix: call Mutex.waitForUnlock instead of locking profile before request (#3409)

* fix: call Mutex.waitForUnlock instead of locking profile before request

Signed-off-by: Trae Yelovich <[email protected]>

* fix: AuthHandler.waitForUnlock

Signed-off-by: Trae Yelovich <[email protected]>

* tests: AuthHandler.waitForUnlock

Signed-off-by: Trae Yelovich <[email protected]>

* fix: add true opt-in support for profile locks w/ extender types

Signed-off-by: Trae Yelovich <[email protected]>

---------

Signed-off-by: Trae Yelovich <[email protected]>

* fix(ds): Pass correct DS name in `stat` when doing remote lookup (#3407)

* fix: use path.basename and helper fn to extract DS name

Signed-off-by: Trae Yelovich <[email protected]>

* test: add unit test to verify proper DS name

Signed-off-by: Trae Yelovich <[email protected]>

* chore: update changelog

Signed-off-by: Trae Yelovich <[email protected]>

---------

Signed-off-by: Trae Yelovich <[email protected]>
Co-authored-by: Timothy Johnson <[email protected]>
Signed-off-by: Timothy Johnson <[email protected]>

---------

Signed-off-by: Billie Simmons <[email protected]>
Signed-off-by: Trae Yelovich <[email protected]>
Signed-off-by: Timothy Johnson <[email protected]>
Signed-off-by: Fernando Rijo Cedeno <[email protected]>
Co-authored-by: Trae Yelovich <[email protected]>
Co-authored-by: Timothy Johnson <[email protected]>
Co-authored-by: Fernando Rijo Cedeno <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

4 participants