-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add time started, submitted and ended fields to Jobs table view #3389
Conversation
Signed-off-by: Trae Yelovich <[email protected]>
Signed-off-by: Trae Yelovich <[email protected]>
Signed-off-by: Trae Yelovich <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3389 +/- ##
=======================================
Coverage 93.18% 93.18%
=======================================
Files 120 120
Lines 12490 12492 +2
Branches 2880 2885 +5
=======================================
+ Hits 11639 11641 +2
Misses 850 850
Partials 1 1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Trae Yelovich <[email protected]>
Signed-off-by: Trae Yelovich <[email protected]>
8863fcb
to
271a063
Compare
Signed-off-by: Trae Yelovich <[email protected]>
Signed-off-by: Trae Yelovich <[email protected]>
📅 Suggested merge-by date: 1/24/2025 |
exec-data
fields to Jobs table viewThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @traeok!
Curious if we want to hide some of the columns by default in the Jobs table view? It's nice to have all the properties returned in the z/OSMF response exposed as fields in the table, but showing them all at once might be information overload for the average user.
Signed-off-by: Trae Yelovich <[email protected]>
As discussed offline, I'm going to hold off on this until we add support for persistence in the column selector 😋 this will avoid breaking changes (missing columns by default for power users) and then users can customize the default columns to their liking. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changelog looks good, thanks @traeok
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 😋
Q: should we create a release/3.1
(from main
) branch before we merge this into main?
Proposed changes
Release Notes
Milestone: 3.2.0
Changelog:
Types of changes
Checklist
General
yarn workspace vscode-extension-for-zowe vscode:prepublish
pnpm --filter vscode-extension-for-zowe vscode:prepublish
Code coverage
Deployment