Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add time started, submitted and ended fields to Jobs table view #3389

Merged
merged 9 commits into from
Jan 14, 2025

Conversation

traeok
Copy link
Member

@traeok traeok commented Jan 10, 2025

Proposed changes

image

Release Notes

Milestone: 3.2.0

Changelog:

  • Enhancement: Added Time Started, Time Ended, and Time Submitted job properties to the Jobs table view. #3055
  • Bug fix: Resolved user interface bug with tables that caused an inconsistent table height within the VS Code Panel. #3389

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds or improves functionality)
  • Breaking change (a change that would cause existing functionality to not work as expected)
  • Documentation (Markdown, README updates)
  • Other (please specify above in "Proposed changes" section)

Checklist

General

  • I have read the CONTRIBUTOR GUIDANCE wiki
  • All PR dependencies have been merged and published (if applicable)
  • A GIF or screenshot is included in the PR for visual changes
  • The pre-publish command has been executed:
    • v2 and below: yarn workspace vscode-extension-for-zowe vscode:prepublish
    • v3: pnpm --filter vscode-extension-for-zowe vscode:prepublish

Code coverage

  • There is coverage for the code that I have added
  • I have added new test cases and they are passing
  • I have manually tested the changes

Deployment

  • I have added developer documentation (if applicable)
  • Documentation should be added to Zowe Docs
    • If you're an outside contributor, please post in the #zowe-doc Slack channel to coordinate documentation.
    • Otherwise, please check with the rest of the squad about any needed documentation before merging.
  • These changes may need ported to the appropriate branches (list here):

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.18%. Comparing base (d5ad25f) to head (46ea9a7).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3389   +/-   ##
=======================================
  Coverage   93.18%   93.18%           
=======================================
  Files         120      120           
  Lines       12490    12492    +2     
  Branches     2880     2885    +5     
=======================================
+ Hits        11639    11641    +2     
  Misses        850      850           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@traeok traeok force-pushed the feat/job-table-exec-fields branch from 8863fcb to 271a063 Compare January 10, 2025 19:39
@traeok traeok marked this pull request as ready for review January 10, 2025 19:55
Copy link

📅 Suggested merge-by date: 1/24/2025

@traeok traeok changed the title feat(jobs): Add exec-data fields to Jobs table view feat(jobs): Add time started, submitted and ended fields to Jobs table view Jan 10, 2025
@traeok traeok changed the title feat(jobs): Add time started, submitted and ended fields to Jobs table view feat: Add time started, submitted and ended fields to Jobs table view Jan 10, 2025
t1m0thyj
t1m0thyj previously approved these changes Jan 11, 2025
Copy link
Member

@t1m0thyj t1m0thyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @traeok!

Curious if we want to hide some of the columns by default in the Jobs table view? It's nice to have all the properties returned in the z/OSMF response exposed as fields in the table, but showing them all at once might be information overload for the average user.

@traeok
Copy link
Member Author

traeok commented Jan 13, 2025

Curious if we want to hide some of the columns by default in the Jobs table view? It's nice to have all the properties returned in the z/OSMF response exposed as fields in the table, but showing them all at once might be information overload for the average user.

As discussed offline, I'm going to hold off on this until we add support for persistence in the column selector 😋 this will avoid breaking changes (missing columns by default for power users) and then users can customize the default columns to their liking.

Copy link
Contributor

@anaxceron anaxceron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog looks good, thanks @traeok

@traeok traeok linked an issue Jan 14, 2025 that may be closed by this pull request
@traeok traeok added this to the v3.2.0 milestone Jan 14, 2025
Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😋

Q: should we create a release/3.1 (from main) branch before we merge this into main?

@traeok traeok merged commit f2b54c8 into main Jan 14, 2025
22 checks passed
@traeok traeok deleted the feat/job-table-exec-fields branch January 14, 2025 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

Add date submitted, started, and ended to jobs table view
4 participants