Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2] Port fix for duplicate config watcher events #3378

Merged
merged 3 commits into from
Jan 6, 2025

Conversation

t1m0thyj
Copy link
Member

Proposed changes

Ports #3296 and #3322 to v2-lts branch

Release Notes

Milestone:

Changelog:

  • Fixed an issue where editing a team config file or updating secrets in the OS credential vault could trigger multiple events for a single action
  • Updated the @zowe/cli dependency to v7.29.8 for technical currency

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds or improves functionality)
  • Breaking change (a change that would cause existing functionality to not work as expected)
  • Documentation (Markdown, README updates)
  • Other (please specify above in "Proposed changes" section)

Checklist

General

  • I have read the CONTRIBUTOR GUIDANCE wiki
  • All PR dependencies have been merged and published (if applicable)
  • A GIF or screenshot is included in the PR for visual changes
  • The pre-publish command has been executed:
    • v2 and below: yarn workspace vscode-extension-for-zowe vscode:prepublish
    • v3: pnpm --filter vscode-extension-for-zowe vscode:prepublish

Code coverage

  • There is coverage for the code that I have added
  • I have added new test cases and they are passing
  • I have manually tested the changes

Deployment

  • I have added developer documentation (if applicable)
  • Documentation should be added to Zowe Docs
    • If you're an outside contributor, please post in the #zowe-doc Slack channel to coordinate documentation.
    • Otherwise, please check with the rest of the squad about any needed documentation before merging.
  • These changes may need ported to the appropriate branches (list here):

Further comments

Signed-off-by: Timothy Johnson <[email protected]>
Copy link

codecov bot commented Dec 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.43%. Comparing base (ea61af9) to head (148ff92).
Report is 1 commits behind head on v2-lts.

Additional details and impacted files
@@            Coverage Diff             @@
##           v2-lts    #3378      +/-   ##
==========================================
+ Coverage   93.41%   93.43%   +0.02%     
==========================================
  Files         105      105              
  Lines       11161    11168       +7     
  Branches     2470     2452      -18     
==========================================
+ Hits        10426    10435       +9     
+ Misses        734      733       -1     
+ Partials        1        0       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

zFernand0
zFernand0 previously approved these changes Jan 2, 2025
Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for porting these over! 🙏

LGTM! 😋

packages/zowe-explorer/src/shared/utils.ts Show resolved Hide resolved
traeok
traeok previously approved these changes Jan 3, 2025
Copy link
Member

@traeok traeok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Timothy! I noticed there's a conflict with the changelog, will re-approve once that's resolved

@t1m0thyj t1m0thyj dismissed stale reviews from traeok and zFernand0 via 148ff92 January 6, 2025 14:47
Copy link

sonarqubecloud bot commented Jan 6, 2025

@zFernand0 zFernand0 requested review from traeok and zFernand0 January 6, 2025 14:50
@t1m0thyj t1m0thyj merged commit b43ce97 into v2-lts Jan 6, 2025
22 checks passed
@t1m0thyj t1m0thyj deleted the v2/port-profile-watch-fixes branch January 6, 2025 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

3 participants