Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the Delete Profile menu option #3375

Merged
merged 3 commits into from
Jan 2, 2025
Merged

Remove the Delete Profile menu option #3375

merged 3 commits into from
Jan 2, 2025

Conversation

t1m0thyj
Copy link
Member

Proposed changes

Fixes #3037 by removing "Delete Profile" option from the "Manage Profile" menu as well as the command palette, but leaves the zowe.deleteProfile command intact for backwards compatibility.

Release Notes

Milestone: 3.1.0

Changelog: Removed "Delete Profile" action from the "Manage Profile" menu since this action is currently not supported in Zowe Explorer

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds or improves functionality)
  • Breaking change (a change that would cause existing functionality to not work as expected)
  • Documentation (Markdown, README updates)
  • Other (please specify above in "Proposed changes" section)

Checklist

General

  • I have read the CONTRIBUTOR GUIDANCE wiki
  • All PR dependencies have been merged and published (if applicable)
  • A GIF or screenshot is included in the PR for visual changes
  • The pre-publish command has been executed:
    • v2 and below: yarn workspace vscode-extension-for-zowe vscode:prepublish
    • v3: pnpm --filter vscode-extension-for-zowe vscode:prepublish

Code coverage

  • There is coverage for the code that I have added
  • I have added new test cases and they are passing
  • I have manually tested the changes

Deployment

  • I have added developer documentation (if applicable)
  • Documentation should be added to Zowe Docs
    • If you're an outside contributor, please post in the #zowe-doc Slack channel to coordinate documentation.
    • Otherwise, please check with the rest of the squad about any needed documentation before merging.
  • These changes may need ported to the appropriate branches (list here):

Further comments

Copy link

codecov bot commented Dec 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.17%. Comparing base (05721c3) to head (3c5b81f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3375   +/-   ##
=======================================
  Coverage   93.17%   93.17%           
=======================================
  Files         117      117           
  Lines       12277    12265   -12     
  Branches     2818     2816    -2     
=======================================
- Hits        11439    11428   -11     
+ Misses        837      836    -1     
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@t1m0thyj t1m0thyj requested a review from anaxceron December 26, 2024 14:37
Copy link
Member

@traeok traeok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM, thanks Timothy for the fix!

image

Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😋

@zFernand0 zFernand0 merged commit d5eff93 into main Jan 2, 2025
22 checks passed
@zFernand0 zFernand0 deleted the fix/rm-del-prof-cmd branch January 2, 2025 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

Remove the Delete Profile option for team config files
3 participants