Fix Refresh button in Unix Attributes View

[JillieBeanSim]

Proposed changes

bug fix for Edit Attributes webview refresh button when changes not applied, reverting the view to original values.
#3238

Release Notes

Milestone: 3.1.0

Changelog: Fixed an issue with edit UNIX file attributes refresh button. #3238

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• Enhancement (non-breaking change which adds or improves functionality)
• Breaking change (a change that would cause existing functionality to not work as expected)
• Documentation (Markdown, README updates)
• Other (please specify above in "Proposed changes" section)

Checklist

General

• I have read the CONTRIBUTOR GUIDANCE wiki
• All PR dependencies have been merged and published (if applicable)
• A GIF or screenshot is included in the PR for visual changes
• The pre-publish command has been executed:
  • v2 and below: yarn workspace vscode-extension-for-zowe vscode:prepublish
  • v3: pnpm --filter vscode-extension-for-zowe vscode:prepublish

Code coverage

• There is coverage for the code that I have added
• I have added new test cases and they are passing
• I have manually tested the changes

Deployment

• I have added developer documentation (if applicable)
• Documentation should be added to Zowe Docs
  • If you're an outside contributor, please post in the #zowe-doc Slack channel to coordinate documentation.
  • Otherwise, please check with the rest of the squad about any needed documentation before merging.
• These changes may need ported to the appropriate branches (list here):

Further comments

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.23%. Comparing base (080a8d9) to head (8a5b210).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3354      +/-   ##
==========================================
+ Coverage   93.17%   93.23%   +0.05%     
==========================================
  Files         117      117              
  Lines       12280    12278       -2     
  Branches     2781     2704      -77     
==========================================
+ Hits        11442    11447       +5     
+ Misses        837      830       -7     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

📅 Suggested merge-by date: 12/25/2024

[traeok]

Thanks for looking into this Billie! I noticed that in some scenarios the Refresh button still does not work, I posted a GIF and some context below.

[traeok]

I think we'll still need the onUpdate event listener. Once the node has been updated in the tree, the attributes in the webview are updated because this callback will be fired in getChildren (see line 233 in ZoweUSSNode.ts). Then, on lines 53-57 in this file, the refresh is called on the tree node to get the new attributes.

It seems like removing this causes every other refresh call to work - for example, if I change the permissions in my terminal and then refresh in ZE, the first refresh does not show any changes, but the second one pulls the right permissions:

Also, the onUpdate callback is working as expected in v2. It seems like the onUpdateEmitter might not be firing in v3.

[zFernand0]

I'm seeing the same behavior as Trae.
Also, the GIF shows that the Apply changes button is enabled the second time the refresh button is clicked, even though nothing the user (I) didn't make changes 😅

[github-actions]

Reminder: This pull request has a merge-by date coming up within the next 24 hours. Please review this PR as soon as possible.

@t1m0thyj @zFernand0 @awharn @SanthoshiBoyina1 @likhithanimma1

[traeok]

Considering the timing of the holidays, I've "snoozed" (disabled) the merge-by comments until everyone is back in the office.
(It also shouldn't be posting these on draft PRs 😅)