-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: TypeError when listing data sets after opening one w/ encoding #3348
Conversation
Signed-off-by: Trae Yelovich <[email protected]>
Signed-off-by: Trae Yelovich <[email protected]>
Signed-off-by: Trae Yelovich <[email protected]>
Signed-off-by: Trae Yelovich <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3348 +/- ##
==========================================
+ Coverage 93.13% 93.15% +0.01%
==========================================
Files 117 117
Lines 12244 12245 +1
Branches 2810 2768 -42
==========================================
+ Hits 11404 11407 +3
+ Misses 839 837 -2
Partials 1 1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Trae Yelovich <[email protected]>
LGTM, will let others review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had a hard time reproducing since the error doesn't seen to come up for PDS members (only of PS datasets)
After seeing the GIF in the issue, I realized my mistake in testing 😋
LGTM! 😋
Proposed changes
Resolves #3347
How to test
Following the same steps when using the
main
branch or 3.0.3 VSIX results in a TypeError.Release Notes
Milestone: 3.1.0 (or a 3.0.4 if needed?)
Changelog:
Types of changes
Checklist
General
yarn workspace vscode-extension-for-zowe vscode:prepublish
pnpm --filter vscode-extension-for-zowe vscode:prepublish
Code coverage
Deployment