Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: TypeError when listing data sets after opening one w/ encoding #3348

Merged
merged 5 commits into from
Dec 6, 2024

Conversation

traeok
Copy link
Member

@traeok traeok commented Dec 5, 2024

Proposed changes

Resolves #3347

How to test

  1. Set a valid search pattern on a profile in your Data Sets tree.
  2. Open one of the datasets in the list with a specific encoding - right-click -> "Open with Encoding"
  3. Select an encoding to open the data set in an editor tab.
  4. Once opened, set a search pattern on your profile that returns no results (ex: PROWOBUF).
  5. Then, set the same search pattern used in step 1.
  6. Once the search is finished, the data sets are listed without any errors.

Following the same steps when using the main branch or 3.0.3 VSIX results in a TypeError.

Release Notes

Milestone: 3.1.0 (or a 3.0.4 if needed?)

Changelog:

  • Fixed an issue where listing data sets resulted in an error after opening a data set with an encoding. #3347

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds or improves functionality)
  • Breaking change (a change that would cause existing functionality to not work as expected)
  • Documentation (Markdown, README updates)
  • Other (please specify above in "Proposed changes" section)

Checklist

General

  • I have read the CONTRIBUTOR GUIDANCE wiki
  • All PR dependencies have been merged and published (if applicable)
  • A GIF or screenshot is included in the PR for visual changes
  • The pre-publish command has been executed:
    • v2 and below: yarn workspace vscode-extension-for-zowe vscode:prepublish
    • v3: pnpm --filter vscode-extension-for-zowe vscode:prepublish

Code coverage

  • There is coverage for the code that I have added
  • I have added new test cases and they are passing
  • I have manually tested the changes

Deployment

  • I have added developer documentation (if applicable)
  • Documentation should be added to Zowe Docs
    • If you're an outside contributor, please post in the #zowe-doc Slack channel to coordinate documentation.
    • Otherwise, please check with the rest of the squad about any needed documentation before merging.
  • These changes may need ported to the appropriate branches (list here):

Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.15%. Comparing base (7f253c1) to head (2076491).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3348      +/-   ##
==========================================
+ Coverage   93.13%   93.15%   +0.01%     
==========================================
  Files         117      117              
  Lines       12244    12245       +1     
  Branches     2810     2768      -42     
==========================================
+ Hits        11404    11407       +3     
+ Misses        839      837       -2     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adam-wolfe
Copy link
Contributor

LGTM, will let others review.

Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a hard time reproducing since the error doesn't seen to come up for PDS members (only of PS datasets)

After seeing the GIF in the issue, I realized my mistake in testing 😋

LGTM! 😋

@JillieBeanSim JillieBeanSim merged commit dda72a0 into main Dec 6, 2024
23 checks passed
@JillieBeanSim JillieBeanSim deleted the fix/set-encoding-after-ctx branch December 6, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

Issue with listing data sets after opening with encoding
6 participants