Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit attributes refresh not updating values #3238

Open
JillieBeanSim opened this issue Oct 14, 2024 · 2 comments · May be fixed by #3354
Open

Edit attributes refresh not updating values #3238

JillieBeanSim opened this issue Oct 14, 2024 · 2 comments · May be fixed by #3354
Assignees
Labels
bug Something isn't working priority-medium Not functioning - next quarter if capacity permits Research Needed severity-medium Bug where workaround exists or that doesn't prevent the usage of Zowe. Just makes it more complex.

Comments

@JillieBeanSim
Copy link
Contributor

Describe the bug

Edit attributes refresh not updating/reverting values

To Reproduce

Steps to reproduce the behavior:

  1. Go to USS tree view and enter a filter search, locating a file to view Attributes
  2. Right-click on file and select Edit Attributes
  3. Change some values but do not apply, instead click the refresh
  4. See attributes not updated/reverted after refresh

Expected behavior

In this scenario, I would assume the refresh would work similar to cancel updating the webview back to the original values.

Desktop (please complete the following information):

  • OS: macos
  • Zowe Explorer Version: 3.0.1
  • (Optional) Zowe CLI Version:
  • (Optional) Are you using Secure Credential Store?

Additional context

Copy link

Thank you for creating a bug report.
We will investigate the bug and evaluate its impact on the product.
If you haven't already, please ensure you have provided steps to reproduce the bug and as much context as possible.

@traeok
Copy link
Member

traeok commented Oct 14, 2024

I debugged this for a bit - when clicking the "Refresh" button, the onUpdate event should fire for USS nodes. This event does not fire in v3.0.0 or v3.0.1 after clicking Refresh. Notice that when the button is clicked, the "Last refreshed" timestamp never updates. Since the logic for the onUpdate event listener is never executed, the webview doesn't receive the new attributes and therefore the timestamp is not updated.

This may be due to a regression between v2 and v3 for the getChildren function. The "Edit Attributes" view uses refreshElement for both v2 and v3 to trigger a call to getChildren, updating the node attributes as a result. In v3, however, the getChildren function doesn't end up updating the node attributes and the event is never fired. It's very strange as the children array starts with the child node (as expected), but by the time the function makes the API call, the cached list of children is empty... maybe another race condition?

@zFernand0 zFernand0 added Research Needed severity-medium Bug where workaround exists or that doesn't prevent the usage of Zowe. Just makes it more complex. labels Oct 17, 2024
@JTonda JTonda added the priority-medium Not functioning - next quarter if capacity permits label Oct 22, 2024
@zowe-robot zowe-robot moved this from New Issues to Medium Priority in Zowe Explorer for VS Code Oct 22, 2024
@JillieBeanSim JillieBeanSim self-assigned this Dec 9, 2024
@JillieBeanSim JillieBeanSim moved this from Medium Priority to In Progress in Zowe Explorer for VS Code Dec 9, 2024
@JillieBeanSim JillieBeanSim linked a pull request Dec 10, 2024 that will close this issue
15 tasks
@JillieBeanSim JillieBeanSim linked a pull request Dec 11, 2024 that will close this issue
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority-medium Not functioning - next quarter if capacity permits Research Needed severity-medium Bug where workaround exists or that doesn't prevent the usage of Zowe. Just makes it more complex.
Projects
Status: In Progress
Development

Successfully merging a pull request may close this issue.

4 participants