IJMP-1630 Added initial processing of the global Zowe team conf file #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ATsikhamirau
approved these changes
Jun 25, 2024
ktsytsen
force-pushed
the
feature/IJMP-1630-global-conf
branch
from
67252d1 to
da4515b
Compare
KUGDev
reviewed
Jun 25, 2024
| @@ -57,21 +67,42 @@ class UpdateZoweConfigAction : DumbAwareAction() { | |||
| return | |||
| } | |||
| val vFile = e.getData(CommonDataKeys.VIRTUAL_FILE) | |||
| if (vFile?.path != "${project.basePath}/$ZOWE_CONFIG_NAME") { | |||
| var type = ZoweConfigType.GLOBAL | |||
| if (vFile?.path != ZoweConfigServiceImpl.getZoweConfigLocation( | |||
There was a problem hiding this comment.
if (
vFile?.path != ZoweConfigServiceImpl.getZoweConfigLocation(project, ZoweConfigType.LOCAL)
&& vFile?.path != ZoweConfigServiceImpl.getZoweConfigLocation(project, ZoweConfigType.GLOBAL)
)
There was a problem hiding this comment.
- better to use val zoweLocalConfigLocation and val zoweGlobalConfigLocation outside both actionPerformed and update functions
| @@ -40,11 +41,20 @@ class UpdateZoweConfigAction : DumbAwareAction() { | |||
| e.presentation.isEnabledAndVisible = false | |||
| return | |||
| } | |||
|
|
|||
| var type = ZoweConfigType.GLOBAL | |||
| if (e.getData(CommonDataKeys.VIRTUAL_FILE)?.path == ZoweConfigServiceImpl.getZoweConfigLocation( | |||
There was a problem hiding this comment.
val zoweLocalConfigLocation = ZoweConfigServiceImpl.getZoweConfigLocation(project, ZoweConfigType.LOCAL)
if (e.getData(CommonDataKeys.VIRTUAL_FILE)?.path == zoweConfigLocalLocation)
| e.presentation.isEnabledAndVisible = false | ||
| return | ||
| } | ||
| if (vFile.path == ZoweConfigServiceImpl.getZoweConfigLocation(project, ZoweConfigType.LOCAL)) |
ktsytsen
force-pushed
the
feature/IJMP-1630-global-conf
branch
from
da4515b to
f617525
Compare
KUGDev
approved these changes
Jun 25, 2024
ktsytsen
force-pushed
the
feature/IJMP-1630-global-conf
branch
2 times, most recently
from
5d02bea to
769c1e7
Compare
dnlsv
approved these changes
Jun 26, 2024
Signed-off-by: Katsiaryna Tsytsenia <[email protected]>
ktsytsen
force-pushed
the
feature/IJMP-1630-global-conf
branch
from
769c1e7 to
788e502
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.