Fix an incorrect check in the recovery router (v2) #448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
ifakhrutdinov
changed the title
ifakhrutdinov
force-pushed
the
bugfix/bad-cellpool-logic-in-recovery
branch
from
b137cc9 to
f420084
Compare
The recovery facility might erroneously free the state cell-pool if an ABEND occurs right after the ESTAEX has been set but before any recovery states with the retry option have been pushed; this issued is caused by an incorrectly coded check in the recovery router code (the check is inverted). The commit fixes the incorrect instruction and adds some code to leave "bread crumbs" when the state cell-pool is deleted. Fixes: #446 Signed-off-by: Irek Fakhrutdinov <[email protected]>
ifakhrutdinov
force-pushed
the
bugfix/bad-cellpool-logic-in-recovery
branch
from
f420084 to
1ecbdb4
Compare
ifakhrutdinov
added
the
priority-high
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recovery facility might erroneously free the state cell-pool if an ABEND occurs right after the ESTAEX has been set but before any recovery states with the retry option have been pushed; this issued is caused by an incorrectly coded check in the recovery router code (the check is inverted).
Proposed changes
The PR fixes the incorrect instruction and adds some code to leave "bread crumbs" when the state cell-pool is deleted.
This PR addresses Issue: #446
Type of change
Please delete options that are not relevant.
PR Checklist
Please delete options that are not relevant.
Testing
There is no reliable way to reproduce this, but in the context of the cross-memory server, one could write a service which disables all the recovery states and then ABENDs on purpose; all the subsequent calls to this server should ABEND without the fix.