Made the bytes to be encoded for base64 scheme to be divisble by 3 #431
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…g scheme
Proposed changes
When using base64 encoding, the number bytes encoded, causes artifacts if its not divisible by 3 for files larger than 1MB. Currently, this is value is FILE_STREAM_BUFFER_SIZE(defined as 1024000). To fix this issue for the base64 condition we decrease it by 1 to make it divisible by 3.
There is also a comment added to modify this part of code incase there is a change in FILE_STREAM_BUFFER_SIZE value in the future.
This PR addresses Issue: zowe/zss#657
Type of change
PR Checklist
Please delete options that are not relevant.
Testing
You can confirm by viewing a file of size greater than 1MB on the zlux-editor or get a file with 'responseType=B64'.
Further comments