Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: respect common env variables #347

Merged
merged 9 commits into from
Dec 19, 2024
Merged

fix: respect common env variables #347

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
db4cba3
fix: respect common env variables
zFernand0 Nov 18, 2024
7768995
review: fix lint issue and update changelog
zFernand0 Nov 18, 2024
4580473
Merge branch 'main' into fix-346
zFernand0 Nov 18, 2024
f2b264a
docs: add small doc entry
zFernand0 Nov 25, 2024
014dae6
chore: add doc-build steps
zFernand0 Dec 11, 2024
7de93d0
chore: add npm scripts to help remember build steps
zFernand0 Dec 11, 2024
c0e1ca2
chore: update npm script :yum:
zFernand0 Dec 11, 2024
5f4cd23
minor edit to Reqs page
anaxceron Dec 18, 2024
c3fa843
Merge pull request #348 from zowe/anax-advanced-usage
anaxceron Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ All notable changes to the Zowe Client Python SDK will be documented in this fil
### Enhancements

- Turning off logger at the class-constructor level [#316](https://github.com/zowe/zowe-client-python-sdk/issues/316)
- Added support for commonly used environmental variables, like `REQUESTS_CA_BUNDLE` and `CURL_CA_BUNDLE`. [#346](https://github.com/zowe/zowe-client-python-sdk/issues/346)

### Bug Fixes

Expand Down
6 changes: 2 additions & 4 deletions src/core/zowe/core_for_zowe_sdk/request_handler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,10 +98,8 @@ def __send_request(self, stream: bool = False):
stream : bool
Flag indicates whether it is a streaming requests.
"""
session = self.session
request_object = requests.Request(method=self.__method, **self.__request_arguments)
prepared = session.prepare_request(request_object)
self.__response = session.send(prepared, stream=stream, **self.session_arguments)
self.__response = self.session.request(
method=self.__method, stream=stream, **self.session_arguments, **self.__request_arguments)

def __del__(self):
"""Clean up the REST session object once it is no longer needed anymore."""
Expand Down
Loading