Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 3.13 to Python version matrix and fix audit workflow #338

Merged
merged 4 commits into from
Oct 15, 2024

Conversation

t1m0thyj
Copy link
Member

What It Does

How to Test

Review Checklist
I certify that I have:

Additional Comments

Copy link

codecov bot commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.10%. Comparing base (3a32dee) to head (7df6861).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #338      +/-   ##
==========================================
+ Coverage   89.07%   89.10%   +0.03%     
==========================================
  Files          65       65              
  Lines        3249     3258       +9     
==========================================
+ Hits         2894     2903       +9     
  Misses        355      355              
Flag Coverage Δ
unittests 89.10% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@t1m0thyj t1m0thyj marked this pull request as ready for review October 14, 2024 14:59
Copy link
Member

@traeok traeok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Timothy

Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😋
should we drop 3.8 since it's not receiving security fixes (I believe)?

Unsupported version

@t1m0thyj t1m0thyj merged commit 0bc1668 into main Oct 15, 2024
22 checks passed
@t1m0thyj t1m0thyj deleted the ci/fix-audit-workflow branch October 15, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

5 participants